Bug 457975 - Click-and-hold enters Selection Mode, but tap-and-hold does not
Summary: Click-and-hold enters Selection Mode, but tap-and-hold does not
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: Selection Mode (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-08-16 21:27 UTC by Nate Graham
Modified: 2022-10-16 07:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 22.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-08-16 21:27:23 UTC
Everything KDE from current git master.


STEPS TO REPRODUCE
1. Open Dolphin.
2. Click-and-hold on an item using a pointing device.

OBSERVED RESULT
Dolphin enters Selection mode. See also Bug 457973.


STEPS TO REPRODUCE
1. Open Dolphin.
2. Press-and-hold on an item using a touchscreen

OBSERVED RESULT
Dolphin shows a context menu but does not enter selection mode.


These behaviors aren't quite right. Click-and-hold should generally do nothing when using a pointing device, while press-and-hold using a touch device should enter Selection Mode rather than showing the context menu; the context-sensitive Selection Mode toolbar is more or less a touch-friendly replacement for the context menu. It's especially important that press-and-hold enter selection mode on touch since the user likely won't have access to the spacebar keyboard shortcut.
Comment 1 Felix Ernst 2022-08-24 09:48:54 UTC
>press-and-hold using a touch device should enter Selection Mode rather
>than showing the context menu

I agree, that is not implemented yet.

>Click-and-hold should generally do nothing when using a pointing device

I implemented that one based on Andy's feedback here:
https://invent.kde.org/system/dolphin/-/merge_requests/273#note_305006

Andy mentioned the advantage of this.
Not sure how bad the downsides of this are. One potential issue I see is that users might be click-and-holding to begin a drag and drop operation and then be surprised by selection mode triggering because they didn't move their mouse fast enough. I had this tested and working originally. I just tested again if this could be a problem and it currently is because of Bug 457973. But if that bug was already fixed it probably wouldn't be.

I want to mention that removing the behaviour of entering selection mode when click-and-holding is as easy as removing the line "        Q_EMIT selectionModeChangeRequested(true);" here: https://invent.kde.org/system/dolphin/-/blob/master/src/kitemviews/kitemlistcontroller.cpp#L1063
This would also fix Bug 457973. Easy profits!

For now we should probably figure out if we want click-and-hold with a pointing device to enter selection mode or not because this might affect the necessary implementation to fix the other touch device behaviour change that is being requested here.
Comment 2 Nate Graham 2022-08-24 09:53:10 UTC
I think we should probably never enter Selection Mode with click-and-hold using a pointing device. In general users find this surprising and don't like it. For reference, we just removed this from Plasma in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2031.
Comment 3 Bug Janitor Service 2022-08-26 10:51:41 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/439
Comment 4 Felix Ernst 2022-08-27 09:41:03 UTC
Git commit 4ddc4159ed5d9fb6e7b7c6edc1b04460f87c984b by Felix Ernst.
Committed on 27/08/2022 at 09:40.
Pushed by felixernst into branch 'master'.

This commit removes the ability to enter selection mode by
click-and-holding with a pointing device like a mouse.

This functionality was originally implemented because it seemed
useful to save users the effort of entering selection mode
explicitly by using its corresponding action.

However, click-and-holding to trigger anything is not really an
expected behaviour. (This contrasts with touch devices where
press-and-holding is common to trigger something.)

Aside from the above reasoning, the click-and-hold behaviour was
also buggy so that selection mode was entered in a couple of
situations that weren't strictly about click-and-holding.

So this commit removes the functionality and the bugs.
Related: bug 457973, bug 458129

M  +0    -1    src/kitemviews/kitemlistcontroller.cpp

https://invent.kde.org/system/dolphin/commit/4ddc4159ed5d9fb6e7b7c6edc1b04460f87c984b