Bug 457823 - Author field for today's APOD contained excessive information
Summary: Author field for today's APOD contained excessive information
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Unmaintained
Component: Picture of the Day (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-13 05:01 UTC by Nate Graham
Modified: 2022-08-14 00:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25.5
Sentry Crash Report:


Attachments
Today's APOD (365.64 KB, image/jpeg)
2022-08-13 05:01 UTC, Nate Graham
Details
20220813 APOD.html (9.19 KB, text/html)
2022-08-13 17:15 UTC, Fushan Wen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-08-13 05:01:52 UTC
Created attachment 151297 [details]
Today's APOD

See attached screenshot.

Looks like the text label doesn't wrap either.
Comment 1 Bug Janitor Service 2022-08-13 17:08:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/217
Comment 2 Fushan Wen 2022-08-13 17:15:28 UTC
Created attachment 151302 [details]
20220813 APOD.html
Comment 3 Bug Janitor Service 2022-08-13 17:28:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/218
Comment 4 Fushan Wen 2022-08-14 00:26:51 UTC
Git commit 3ad7c5bc0d09b86bb2761931e46ed8f2f65e68c0 by Fushan Wen.
Committed on 13/08/2022 at 17:03.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: set maximum width of title and author labels

Layout properties should be given to Row, which contains the selectable
labels.

M  +8    -8    wallpapers/potd/package/contents/ui/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/3ad7c5bc0d09b86bb2761931e46ed8f2f65e68c0
Comment 5 Fushan Wen 2022-08-14 00:27:32 UTC
Git commit 26c6329ce877f5dfc7be6f42d567295c259e8cdf by Fushan Wen.
Committed on 14/08/2022 at 00:27.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: do not match colon in regex

Sometimes the author label does not contain a colon, for example,
on 20220813, the author field does not contain a colon.
FIXED-IN: 5.25.5

M  +1    -1    wallpapers/potd/plugins/providers/apodprovider.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/26c6329ce877f5dfc7be6f42d567295c259e8cdf
Comment 6 Fushan Wen 2022-08-14 00:28:18 UTC
Git commit ae5ddf61e8e67d6855b453b603b7b1c2aa3d7fb6 by Fushan Wen.
Committed on 14/08/2022 at 00:28.
Pushed by fusionfuture into branch 'Plasma/5.25'.

wallpapers/potd: do not match colon in regex

Sometimes the author label does not contain a colon, for example,
on 20220813, the author field does not contain a colon.
FIXED-IN: 5.25.5


(cherry picked from commit 26c6329ce877f5dfc7be6f42d567295c259e8cdf)

M  +1    -1    wallpapers/potd/plugins/providers/apodprovider.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/ae5ddf61e8e67d6855b453b603b7b1c2aa3d7fb6