Bug 457666 - NeoChat marking messages as read after typing indicator stopped appearing
Summary: NeoChat marking messages as read after typing indicator stopped appearing
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-09 10:34 UTC by Jan Bidler
Modified: 2022-11-20 16:48 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/network/neochat/commit/cd257137baf727722ab32329fd122775ba404bcf
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Bidler 2022-08-09 10:34:16 UTC 
SUMMARY
The typing indicator can mark messages as read. This shouldn't happen.

STEPS TO REPRODUCE
1. Be in a room with some user
2. Unfocus matrix client
3. Let the other user send a few messages, and then stop typing

OBSERVED RESULT
After the other user stopped typing and the typing indicator disappeared, all messages will be marked as read

EXPECTED RESULT
The messages should not get marked as read.

SOFTWARE/OS VERSIONS
Linux: Arch Linux
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
NeoChat: self compiled flatpak
Comment 1 Bug Janitor Service 2022-11-20 11:11:43 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/644
Comment 2 James Graham 2022-11-20 16:48:41 UTC 
Git commit cd257137baf727722ab32329fd122775ba404bcf by James Graham.
Committed on 20/11/2022 at 16:48.
Pushed by nvrwhere into branch 'master'.

Fix typing indicator causing markAllMessagesAsRead

Move the typing indicator out of the listView header so it doesn't resize the view when appearing and disappearing causing all messages to be marked as read

M  +2    -2    src/qml/Page/RoomPage.qml

https://invent.kde.org/network/neochat/commit/cd257137baf727722ab32329fd122775ba404bcf