Bug 457322 - When editing toolbar, hide text does not work for Text Selection and Annotations
Summary: When editing toolbar, hide text does not work for Text Selection and Annotations
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 22.04.3
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-30 22:45 UTC by doncbugs
Modified: 2022-08-31 20:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
text showing next to icon even when disabled (23.21 KB, image/png)
2022-07-30 22:45 UTC, doncbugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doncbugs 2022-07-30 22:45:09 UTC
Created attachment 151016 [details]
text showing next to icon even when disabled

SUMMARY
Editing the toolbar in Okular and with the Configure Toolbar option, setting Text Selection or Annotations to Hide the text alongside icons appears to do nothing. Thus, the text cannot be removed from either button.


STEPS TO REPRODUCE
1. With a document (I used a pdf) open, Right-click the toolbar and select Configure Toolbars...
2. Switch to the "Main Toolbar <okular_part>"
3. Select either "Selection Tools" or "Quick Annotations"
4. Click the "Change Text..." button
5. Check the "Hide text when toolbar shows text alongside icons" checkbox, hit OK and Apply.

OBSERVED RESULT
The text is still present

EXPECTED RESULT
The text should be hidden. The "Browse" button responds correctly when text is hidden. Not sure where the text for annotations or selection are even coming from.

Operating System: KDE neon Testing Edition
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Kernel Version: 5.15.0-41-generic (64-bit)
Graphics Platform: X11
Comment 1 Bug Janitor Service 2022-08-13 21:37:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/643
Comment 2 Albert Astals Cid 2022-08-31 20:07:04 UTC
Git commit 3304038d1de0bead5e67275a7a6a9885afe0332d by Albert Astals Cid.
Committed on 31/08/2022 at 19:59.
Pushed by aacid into branch 'release/22.08'.

ToggleActions: Obey "don't show text" for a particular action toolbar setting

M  +15   -0    part/toggleactionmenu.cpp
M  +8    -0    part/toggleactionmenu.h

https://invent.kde.org/graphics/okular/commit/3304038d1de0bead5e67275a7a6a9885afe0332d