Bug 457319 - animation timeline- copy/paste active layer bug
Summary: animation timeline- copy/paste active layer bug
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-30 21:55 UTC by ahmett
Modified: 2022-10-10 18:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
video referance about paste problem (1.17 MB, video/mp4)
2022-07-30 21:57 UTC, ahmett
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ahmett 2022-07-30 21:55:28 UTC
I tried to show it in the video. Although it works fine in version 5.06, the part copied in beta-2 remembers the first selected part when pasted into the new frame. and if the onion skin is open it copies it too. then when I try to copy the 2nd frame to 3, it still pastes the first frame I copied.
thanks in advance.
Comment 1 ahmett 2022-07-30 21:57:35 UTC
Created attachment 151012 [details]
video referance about paste problem
Comment 2 Halla Rempt 2022-08-01 12:59:52 UTC
I've asked Emmet and Eoin to take a look.
Comment 3 Emmet O'Neill 2022-08-02 01:04:41 UTC
Ok, I've confirmed this bug. Thanks for the report, Ahmett.
We'll look into addressing this one as soon as we can.
Comment 4 ahmett 2022-08-02 06:29:04 UTC
Hi emmet,your welcome.
in addition to this topic.
when we did normal paste in 5.06, only the copied one frame was pasted into a new layer.  Now it duplicates all frames to a new column.
Comment 5 Eoin O'Neill 2022-08-03 23:05:19 UTC
Git commit 72bad700c6835dcd6619fb2d687b862a6353624c by Eoin O'Neill.
Committed on 03/08/2022 at 23:01.
Pushed by eoinoneill into branch 'master'.

Fix copy+paste working strangely with animated layers.

Achieved this by "burning" the current frameid into copied paint
devices. This is the desired behavior, as copy/pasted selections
should really be a simple WYSIWYG interaction where the visible
contents of a selection are copied.

M  +26   -0    libs/image/kis_paint_device.cc
M  +18   -0    libs/image/kis_paint_device.h
M  +19   -52   libs/ui/actions/kis_selection_action_factories.cpp

https://invent.kde.org/graphics/krita/commit/72bad700c6835dcd6619fb2d687b862a6353624c
Comment 6 Eoin O'Neill 2022-10-10 18:47:15 UTC
Git commit ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7 by Eoin O'Neill.
Committed on 10/10/2022 at 18:37.
Pushed by eoinoneill into branch 'krita/5.1'.

Fix copy+paste working strangely with animated layers.

Achieved this by "burning" the current frameid into copied paint
devices. This is the desired behavior, as copy/pasted selections
should really be a simple WYSIWYG interaction where the visible
contents of a selection are copied.
Related: bug 459763
(cherry picked from commit 72bad700c6835dcd6619fb2d687b862a6353624c)

M  +26   -0    libs/image/kis_paint_device.cc
M  +18   -0    libs/image/kis_paint_device.h
M  +19   -52   libs/ui/actions/kis_selection_action_factories.cpp

https://invent.kde.org/graphics/krita/commit/ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7