Bug 457200 - If both files and folders are dragged between split views, dolphin copies only the files
Summary: If both files and folders are dragged between split views, dolphin copies onl...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 22.07.80
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-07-27 14:23 UTC by Kishore Gopalakrishnan
Modified: 2022-08-15 21:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2022-07-27 14:23:15 UTC
SUMMARY
When the user selects multiple items (both files and folders) and tries to copy them by dragging between split views, only the selected files are copied, while the selected folders are ignored.

STEPS TO REPRODUCE
1. Open split view, with different locations in the views
2. In the left one, select one file along with one folder
3. Drag selected items to the other split view and choose to copy

OBSERVED RESULTS
Only the selected files are copied, while the selected folders are not copied

EXPECTED RESULTS
All selected items (both files and folders) should be copied

SOFTWARE VERSIONS
dolphin 22.07.80
Operating System: Arch Linux
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.18.13-arch1-1 (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
If all the selected items are folders (i.e. no files are selected), they get copied as expected
Comment 1 Kishore Gopalakrishnan 2022-07-31 05:45:51 UTC
Reverting the following commit fixes the issue for me:

8d7e600f63a1961294dfe2c278a710b4ce0716e9 is the first bad commit
commit 8d7e600f63a1961294dfe2c278a710b4ce0716e9
Author: Harald Sitter <sitter@kde.org>
Date:   Tue May 3 13:57:09 2022 +0200

    portalize drag urls
    
    this enables sandboxed application to receive drop events

 src/kitemviews/kitemlistcontroller.cpp     | 4 +++-
 src/panels/folders/treeviewcontextmenu.cpp | 1 +
 src/views/dolphinview.cpp                  | 5 ++++-
 3 files changed, 8 insertions(+), 2 deletions(-)
Comment 2 Felix Ernst 2022-08-13 19:25:16 UTC
Thanks for testing the Beta and notifying us.

Confirmed bug on current master. Confirmed bug doesn't exist on 22.08 after reverting said commit.

Sorry for being an inconvenience Harald, but I feel like this should be dealt with somewhat fast. The only solution I would know is reverting. Would you please look into it or let me know quickly if you can't deal with this quickly?

I fear that a user might copy files and folders over and then delete them at the old location not knowing that the copying of the folders actually didn't happen. I feel like it might even make sense to ask for the faulty commit to not be included for the 22.08 release if there is still time to prevent this.

The release is on 18th August. So in five days.
Comment 3 Felix Ernst 2022-08-15 10:13:44 UTC
I have now reverted said commit on release/22.08 with https://invent.kde.org/system/dolphin/-/commit/57909ebe66fd4aa83d1fbaf2c746d408451e80cb. I will contact the release team hoping that the revert can be included in the 22.08.0 release. Otherwise the revert will be in the 22.08.1 release.

This bug report stays open because the bug still exists on master.
Comment 5 Felix Ernst 2022-08-15 21:37:05 UTC
I guess this bug is resolved then.

It is resolved for the 22.08 release of Dolphin because the commit was reverted. Albert just let me know that he has updated the tarball file (https://mail.kde.org/pipermail/release-team/2022-August/012751.html ) so users shouldn't be affected by this.

For the 22.12 release of Dolphin the commit stays but we can expect that most people will have a frameworks version that contains

>https://invent.kde.org/frameworks/kcoreaddons/-/commit/231c98e21f0dbb0e65014abc033b7022bf559877

until then.