Bug 457175 - Elisa priorities Cover image file instead of embedded cover
Summary: Elisa priorities Cover image file instead of embedded cover
Status: RESOLVED INTENTIONAL
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-26 21:56 UTC by indecisiveautomator
Modified: 2022-07-28 00:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description indecisiveautomator 2022-07-26 21:56:58 UTC
SUMMARY
I am running elisa-git from the AUR, version 22.11.70.

Elisa will prioritize a cover image file over an embedded cover for a song. If a song has an embedded cover but is in a folder with a "cover.jpg", that file will take priority over any embedded cover. I'm not sure if this is intended behaviour but the inverse case seems more expected to me: Using a cover image file as a fallback and checking for embedded cover art first.

In my case, I have a messy music library, and I rely on music players to sort my collection for me. My music folder is very disorganised and I have a bunch of albums and singles in one big folder, correctly tagged and with embedded album art. One album happened to come with a "cover.png" and now all albums in that folder use the "cover.png" even when they have embedded cover art of their own.

if this is intended behaviour, maybe there could be a setting for a user to decide whether "cover.png" type files should be prioritized or whether they are a fallback if no cover art is found.


STEPS TO REPRODUCE
1. Add a song with embedded cover art into a folder
2. Add an image called "cover.png" or "cover.jpg" into this folder
3. Add this music folder to Elisa's music library
4. That song will use the "cover.png" file instead of its embedded art


OBSERVED RESULT
Elisa uses a cover image file over embedded cover art.


EXPECTED RESULT
Elisa should use the embedded cover art when available and only use a cover image file as a fallback.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.18.14-zen1-1-zen
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Probably not applicable to the latest stable Elisa, as I believe there were various fixes related to reading embedded cover art that are currently only in development builds of Elisa (such as Bug 418800), but I could be wrong :-)
Comment 1 Nate Graham 2022-07-27 20:40:10 UTC
Not sure if one is really objectively better than the other; we have to use one by default and fall back to the other. But IMO there is at least some logic to using a separate image first since that's easier for the casual user to change, add, or remove.
Comment 2 indecisiveautomator 2022-07-27 20:47:11 UTC
I see. I think that's disappointing, as users that set the image themselves are being punished by this, such as music collectors. It's also not feasible to change the layout of a music library if one uses multiple music players, so moving the offending albums into a separate folder isn't exactly feasible in this case.

I see what you mean about a regular user use case, but is there any reason why this couldn't be a toggle? This problem is preventing me from using Elisa which is the only reason I am trying to make my point on this so hard :-)
Comment 3 Nate Graham 2022-07-27 22:23:41 UTC
I think this sort of thing is too esoteric to add an option for, especially because there are three potential superior solutions:
1. Standardize on cover files by removing embedded album art everywhere
2. Standardize on embedded album art by deleting the cover files everywhere
3. Remove the cover files for any albums with embedded album art

Ultimately this bug only affects people with messy music libraries, and the solution is to clean up your music library. :) 

For your specific use case, it sounds like #3 is the best. Just delete the cover files that are causing this problem.
Comment 4 indecisiveautomator 2022-07-28 00:11:15 UTC
To do this with the offending albums I would have to find which albums don't use embedded cover art and embed it using music software that does display the embedded cover art over the image file, which is silly to me personally.

I totally understand the perspective however and thanks for elaborating further, but I expect the software to do the heavy lifting for me with organising my collections. Strawberry does this though it's interface isn't as slick as Elisa's, but I guess I'll just stick to that, especially when I'll have to use that to embed the cover art in the first place.

Thanks for explaining the rationale, Elisa is great but just doesn't seem to fit my I suppose edge case.