Bug 457077 - Favorites category uses a monochrome icon, whereas everything else uses a colorful icon
Summary: Favorites category uses a monochrome icon, whereas everything else uses a col...
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on: 474275
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-24 15:05 UTC by D3XT3R
Modified: 2023-09-07 21:03 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Monochrome icons. (240.66 KB, image/png)
2022-07-24 15:05 UTC, D3XT3R
Details

Note You need to log in before you can comment on or make changes to this bug.
Description D3XT3R 2022-07-24 15:05:39 UTC
Created attachment 150871 [details]
Monochrome icons.

In order to maintain consistency, the monochrome icons of the Favorites and Help items should be replaced by colored icons.
Comment 1 Nate Graham 2022-07-24 17:46:49 UTC
The help icon has already been fixed in https://invent.kde.org/frameworks/breeze-icons/-/commit/acc75ff7762d7de0bd6489abc821dba506c2a43b. Let's use this bug report to track fixing the Favorites icon.
Comment 2 Nate Graham 2022-07-24 20:37:49 UTC
So there are a few problems here:
* in plasma-workspace/applets/kicker/plugin/rootmodel.cpp, we use the `bookmarks` icon which is not semantically correct, as a bookmark is something different from a favorited item.
* If we switched to using either of the more semantically correct `favorite` or `favorites` icon, those icons in the Breeze icon theme are also monochrome at their small sizes

I see two ways we could proceed here:
1. Change the `bookmarks` icon in the Plasma theme to look like a colorful star
2. Change the icon used to `applications-favorites` and create that icon in the Breeze icon theme, ensuring there's a colorful version for both the 22px and 32px sizes.

Noah and Manuel, what do you think?
Comment 3 Nate Graham 2023-09-07 21:02:35 UTC
We'd need a colorful version of this icon. There is `folder-favorites` but that looks like a folder and doesn't quite seem appropriate.