Bug 457076 - Add a tooltip to explain that you can't delete some themes
Summary: Add a tooltip to explain that you can't delete some themes
Status: RESOLVED UPSTREAM
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-07-24 15:00 UTC by Vytautas
Modified: 2022-07-27 20:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vytautas 2022-07-24 15:00:56 UTC
SUMMARY
So right now some themes have a greyed-out "Trash" button. This can confuse some users and it would be nice to have an explanation of why you can't remove it. Maybe hovering over the icon could conjure a popup saying something like "This theme was installed through your distribution's package manager and cannot be removed" or "This is a preinstalled theme and cannot be uninstalled".
Comment 1 Nate Graham 2022-07-26 19:04:07 UTC
Good idea!
Comment 2 Nate Graham 2022-07-27 19:17:29 UTC
I looked into this and unfortunately it's currently not possible, because when we set a tooltip on a disabled button, it's never shown. The fact that the button is disabled keeps it from accepting hover events needed to show a tooltip, for performance reasons. So this would have to be changed in Qt first to allow us to do it.
Comment 3 Vytautas 2022-07-27 20:01:11 UTC
Wouldn't it be possible to have those buttons be enabled, just without any action? (With a grey icon ofc)
Comment 4 Nate Graham 2022-07-27 20:21:58 UTC
No, because then the buttons would still be clickable but do nothing, and people would (rightly) complain about it. In order to work around the Qt limitation, we would have to completely re-implement a "disabled button" status here so that the button looks disabled, and acts disabled, but isn't actually disabled from Qt's perspective, and that's not technically reasonable.
Comment 5 Vytautas 2022-07-27 20:25:23 UTC
(In reply to Nate Graham from comment #4)
> No, because then the buttons would still be clickable but do nothing, and
> people would (rightly) complain about it. In order to work around the Qt
> limitation, we would have to completely re-implement a "disabled button"
> status here so that the button looks disabled, and acts disabled, but isn't
> actually disabled from Qt's perspective, and that's not technically
> reasonable.

Oh, ok understandable