Bug 456888 - Duplicate shortcut keys in tooltips
Summary: Duplicate shortcut keys in tooltips
Status: RESOLVED FIXED
Alias: None
Product: kolourpaint
Classification: Applications
Component: general (other bugs)
Version First Reported In: 22.04.3
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: kolourpaint-support
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-18 22:25 UTC by D3XT3R
Modified: 2022-07-24 10:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Duplicate shortcut keys in tooltips (86.62 KB, image/png)
2022-07-18 22:25 UTC, D3XT3R
Details

Note You need to log in before you can comment on or make changes to this bug.
Description D3XT3R 2022-07-18 22:25:47 UTC
Created attachment 150720 [details]
Duplicate shortcut keys in tooltips

All shortcut keys are duplicated in Kolorpaint tooltips.
Comment 1 Nate Graham 2022-07-19 15:52:20 UTC
Can reproduce. Might be an issue in the common tooltip code, or might be an issue in how Kolourpaint assigns shortcuts. CCing Felix Ernst, who is much more knowledgeable about this than I am.
Comment 2 Bug Janitor Service 2022-07-19 20:38:50 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/kolourpaint/-/merge_requests/22
Comment 3 Felix Ernst 2022-07-19 20:46:14 UTC
I am knowledgeable about this bug because I caused it. ^^'
Comment 4 Felix Ernst 2022-07-24 10:36:27 UTC
Git commit 906b97b482c0ab45526c1deea684d3d37f4c3a45 by Felix Ernst.
Committed on 19/07/2022 at 20:24.
Pushed by felixernst into branch 'master'.

Show keyboard shortcuts in tooltips only once not twice

The tools on the left bar of Kolourpaint show their respective
keyboard shortcuts in their tooltips.

There was a change in KDE frameworks
(https://commits.kde.org/kxmlgui/ecd7cefd8d4b8ddb15b8e3a3e6e9bd5c55a9c12c)
that made it so all tooltips of actions show their keyboard
shortcuts in their tooltips by default.

Together this meant that the keyboard shortcut is shown twice.
This commit fixes this by removing the Kolourpaint-specific code
to show the keyboard shortcut in the tooltip.

M  +0    -33   tools/kpTool.cpp
M  +0    -6    tools/kpTool.h
M  +0    -18   tools/kpToolAction.cpp
M  +0    -3    tools/kpToolAction.h

https://invent.kde.org/graphics/kolourpaint/commit/906b97b482c0ab45526c1deea684d3d37f4c3a45