Bug 456874 - Changes to accent color do not take effect immediately in GTK apps using Breeze GTK theme; they need to be restarted
Summary: Changes to accent color do not take effect immediately in GTK apps using Bree...
Status: CONFIRMED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.25.3
Platform: Other Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-18 17:39 UTC by Mircea Kitsune
Modified: 2022-12-18 09:32 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of Firefox (1.83 MB, image/png)
2022-07-18 17:40 UTC, Mircea Kitsune
Details
Screenshot of Thunderbird (58.69 KB, image/png)
2022-07-18 17:41 UTC, Mircea Kitsune
Details
Screenshot of Dolphin (155.92 KB, image/png)
2022-07-18 17:50 UTC, Mircea Kitsune
Details
screenshot of Brave browser (17.66 KB, image/jpeg)
2022-10-01 07:40 UTC, Sadi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mircea Kitsune 2022-07-18 17:39:34 UTC
SUMMARY
After upgrading to Plasma 5.25.3 to enjoy the new accent color features, I noticed a few issues remain with some applications. When using wallpaper based accent coloring or changing the accent from system settings, parts of the toolbar will sometimes not update in Firefox and Thunderbird. I couldn't reproduce it in any KDE applications where everything seems to work fine, most likely QT apps don't have that problem and this is a GTK bug.

STEPS TO REPRODUCE
1. Make sure you're using the Breeze GTK theme, open Firefox and Thunderbird.
2. In the System Settings go to Colors: Keep changing the color scheme and accent color, also try the wallpaper color with an image slideshow configured in the desktop settings.

OBSERVED RESULT

When certain changes are made, parts of the toolbar in Firefox or Thunderbird may fail to change and remain stuck on the old color. This includes the selection color on websites and in emails, which can be noticed if you click-drag over text in FF and TB to select it: If you open the Bookmarks menu in Firefox and select entries, you may find that has yet another selection color forgotten in between changes. You need to restart the application for those colors to be updated.

EXPECTED RESULT

All colors should notice changes to the accent color or the color scheme and update accordingly.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.18.12-3-MANJARO (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 3700X 8-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: AMD Radeon RX 570 Series
Comment 1 Mircea Kitsune 2022-07-18 17:40:05 UTC
Created attachment 150712 [details]
Screenshot of Firefox
Comment 2 Mircea Kitsune 2022-07-18 17:41:30 UTC
Created attachment 150713 [details]
Screenshot of Thunderbird
Comment 3 Mircea Kitsune 2022-07-18 17:50:52 UTC
Created attachment 150715 [details]
Screenshot of Dolphin

Actually when it comes to the Breeze colorized icons for directories, the issue exist in Dolphin too though it may be for different causes. Some directories don't have their icon updated immediately and require you hit F5 to refresh, including the preview in the sidebar if you have a directory selected. Sometimes even if you refresh the old color still appears on directories, in those cases it seems to go away if I navigate to another path then return and refresh after that.
Comment 4 Nate Graham 2022-07-18 20:30:12 UTC
It's not quite a GTK bug; more like a bug in our theming of GTK apps. They don't dynamically reflect accent color changes in real-time and have to be restarted first.

Related to Bug 438110; possibly the exact same issue, in that fixing that might fix this automatically.
Comment 5 Mircea Kitsune 2022-07-18 22:03:24 UTC
Thanks for clarifying. Please take a look at my last comment too, I seem to have ended up reporting two bugs in one due to them appearing the same: Dolphin also forgets to update the icon colors for directories sometimes, apparently when preview is enabled and the folder contains overlays from what I'm noticing in my own screenshot.
Comment 6 Nate Graham 2022-07-18 22:38:06 UTC
That's a separate issue: Bug 414097.
Comment 7 Sadi 2022-10-01 07:40:16 UTC
Created attachment 152528 [details]
screenshot of Brave browser

I experience a similar problem in the header (tab) bar of Brave web browser using system GTK+ theme: sometimes its color changes only partially, sometimes it doesn't change at all, until I click on it. Hovering on it also causes a similar partial color change, again until I click on it (as seen in the screenshot). 
However, I don't see this in other apps using GTK theme like LibreOffice, Thunderbird, Palemoon web browser, etc. This might be due to each app using GTK+ theme in some different way so that some do experience this problem while some don't???
Comment 8 Sadi 2022-10-01 07:50:55 UTC
Correction: Sorry, my previous observations of other apps  using GTK+ theme, like LibreOffice and Thunderbird, were apparently misleading probably due to a hardly noticeable color change.
I can now confirm that this bug affects them all, although clicking on Thunderbird tab bar doesn't refresh it like Brave browser.
Comment 9 Sadi 2022-12-18 09:32:22 UTC
This appears to have been resolved now for all apps like Brave and Thunderbird other than Dolphin - failing to refresh folder color automatically when accent color changes due to wallpaper change slideshow.

Operating System: SparkyLinux 7
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.6