Created attachment 150650 [details] Screenshot with issues marked SUMMARY The "Add new connection" and "Configuration" subwindows of the Connections KCM currently look awful, they are in a need of some polish. Both of these windows suffer from the same kind of issues: 1. Windows have incorrect background color. 2. Windows have no close buttons on their title bars. 3. Windows have no default buttons set. 4. OK button has wrong capitalization. ("Ok" -> "OK") 5. Bottom buttons are missing their icons. 6. Bottom buttons have inconsistent spacing. All of the problems above are papercut-category issues however crammed together into the very same place they paint a horrible picture. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.25 KDE Plasma Version: 5.25.3 KDE Frameworks Version: 5.96.0 Qt Version: 5.15.5 Graphics Platform: X11
I think windows having incorrect background colours is not a real issue as the colour change only happens because other windows lose focus.
A merge request has been created https://invent.kde.org/plasma/plasma-nm/-/merge_requests/191 A separate bug report for the missing close button has to be filed if not has been already filed as it is a bug in Kwin or Qt and it only affects x11. For the missing icons, I think icons aren't used in button like "OK" or "Cancel" Default buttons aren't usually set in dialogs i believe if i understand it correctly
> I think windows having incorrect background colours is not a real issue as the colour change only happens because other windows lose focus. Look closer. They have "View Background" semantic color instead of "Window Background" as they should. It's clearly an issue.
Created attachment 154585 [details] Icons used on "OK" and "Cancel" buttons > I think icons aren't used in button like "OK" or "Cancel" This is incorrect. Look at this random sampling of KDE apps for example.
(In reply to Nagy Tibor from comment #4) > Created attachment 154585 [details] > Icons used on "OK" and "Cancel" buttons > > > I think icons aren't used in button like "OK" or "Cancel" > This is incorrect. Look at this random sampling of KDE apps for example. Thank you for pointing it out.
Setting default button in qml dialog doesn't seem like something that could easily implemented. Only places where i see default button is implemented is when KStandardGuiItems are used
Git commit 0f0c7aab0ddfc0872a21f323bb947700cef3bce8 by Nate Graham, on behalf of Thenujan Sandramohan. Committed on 20/12/2022 at 17:57. Pushed by ngraham into branch 'master'. KCM: improve visuals and consistency of "Add connection" dialog Changes: - Add icons for buttons - Correct background color for windows - Correct capitalization of "OK" - Correct spacing between buttons FIXED-IN: 5.27 M +13 -2 kcm/qml/AddConnectionDialog.qml M +5 -3 kcm/qml/ConfigurationDialog.qml https://invent.kde.org/plasma/plasma-nm/commit/0f0c7aab0ddfc0872a21f323bb947700cef3bce8