Bug 456734 - Halftone filter Alpha mode defaults to None generator (which seems to have no purpose)
Summary: Halftone filter Alpha mode defaults to None generator (which seems to have no...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Deif Lou
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-15 01:08 UTC by tomtomtomreportingin
Modified: 2022-08-01 14:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tomtomtomreportingin 2022-07-15 01:08:33 UTC
Krita 5.1.0-beta2 (git 973c92a)

SUMMARY
Something I've noticed for a while: when using the Halftone filter, selecting the Alpha mode defaults the generator to None, which seems to have no practical purpose from what I can tell, as it appears to do nothing at all, even when configuring the postprocessing options.

STEPS TO REPRODUCE
1. Utilize the Halftone filter through a filter, filter mask, or filter layer.
2. Select Alpha mode.

OBSERVED RESULT
The default generator is None, which seems to do nothing.

EXPECTED RESULT
The default generator should probably be Screentone like the other modes. Also, if there is no practical purpose to the None mode, it should probably be removed.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.12.12 (appimage)
Comment 1 Deif Lou 2022-08-01 13:49:20 UTC
I guess the screentone generator should be used as a default for the alpha mode. The "none" option is useful in the case when there are multiple channels (rgb, crmyk, etc.). That allows you to not apply the filter to some channels.
Comment 2 Deif Lou 2022-08-01 14:11:27 UTC
Git commit 3d18eb0df19f0177c48256aec48706a37691cf9c by Deif Lou.
Committed on 01/08/2022 at 14:09.
Pushed by deiflou into branch 'master'.

Make the alpha mode in the halftone filter use a default generator instead of none

M  +10   -1    plugins/filters/halftone/KisHalftoneFilter.cpp

https://invent.kde.org/graphics/krita/commit/3d18eb0df19f0177c48256aec48706a37691cf9c
Comment 3 Deif Lou 2022-08-01 14:12:54 UTC
Git commit d44e557f9db748e2fd6d03f64583d89b3262b038 by Deif Lou.
Committed on 01/08/2022 at 14:12.
Pushed by deiflou into branch 'krita/5.1'.

Make the alpha mode in the halftone filter use a default generator instead of none

M  +10   -1    plugins/filters/halftone/KisHalftoneFilter.cpp

https://invent.kde.org/graphics/krita/commit/d44e557f9db748e2fd6d03f64583d89b3262b038