Hi, Konqueror is a great browser, but the only important thing missing and if it is the will to do so, is to insert an adblock integrated into the brawser. Filters don't work well when browsing ads flood the page and it's not pleasant to browse. with regard

Could you please be more explicit? In what ways don't filters work well? What kind of integrated adblock would you like Konqueror to have?

Created attachment 150587 [details]
attachment-12839-0.html

An Adblock that works, such as ublock origin adblock plus, and so on, to
ensure that the navigation is clean. I add the konqueror adblock filters
but they do not determine their action of protection against popup
advertisements and so on ... You can directly integrate an
addons-extensions at least for the protection of the navigation. Thank
you 🙂😉

Il giorno mer 13 lug 2022 alle ore 16:25 Stefano Crocco <
bugzilla_noreply@kde.org> ha scritto:

> https://bugs.kde.org/show_bug.cgi?id=456683
>
> Stefano Crocco <stefano.crocco@alice.it> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |stefano.crocco@alice.it
>
> --- Comment #2 from Stefano Crocco <stefano.crocco@alice.it> ---
> Could you please be more explicit? In what ways don't filters work well?
> What
> kind of integrated adblock would you like Konqueror to have?
>
> --
> You are receiving this mail because:
> You reported the bug.

Il 13/07/22 16:25, Stefano Crocco ha scritto:
> https://bugs.kde.org/show_bug.cgi?id=456683
>
> Stefano Crocco <stefano.crocco@alice.it> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |stefano.crocco@alice.it
>
> --- Comment #2 from Stefano Crocco <stefano.crocco@alice.it> ---
> Could you please be more explicit? In what ways don't filters work well? What
> kind of integrated adblock would you like Konqueror to have?
>
> An Adblock that works, such as ublock origin adblock plus, and so on, to ensure that the navigation is clean. I add the konqueror adblock filters but they do not determine their action of protection against popup advertisements and so on ... You can directly integrate an addons-extensions at least for the protection of the navigation. Thank you 🙂😉
>

I think the main problem is that adblock does not work in WebEngine, it only works in WebKit as far as I can tell

(In reply to avlas from comment #5)
> I think the main problem is that adblock does not work in WebEngine, it only
> works in WebKit as far as I can tell

To be more precise, it also works in WebEngine, but for images only. I don't know whether there was a specific reason to restrict it to images only (maybe for performance). In any case, even on WebKit, Konqueror supports only the most basic features of AdBlock. I'm woking on improving this, but it means rewriting the AdBlock engine, so it's not easy.

(In reply to Stefano Crocco from comment #6)
> (In reply to avlas from comment #5)
> > I think the main problem is that adblock does not work in WebEngine, it only
> > works in WebKit as far as I can tell
> 
> To be more precise, it also works in WebEngine, but for images only. I don't
> know whether there was a specific reason to restrict it to images only
> (maybe for performance). In any case, even on WebKit, Konqueror supports
> only the most basic features of AdBlock. I'm woking on improving this, but
> it means rewriting the AdBlock engine, so it's not easy.

Thanks for your work, Stefano, it's very appreciated!

Regarding adblock images in WebEngine, how does it work exactly? Does it mean images of ads should not be displayed? I'm not sure it is a bug or something but this doesn't work in my end, for instance here https://www.ccma.cat/esport3 (sometimes it seems to work once but refreshing makes all images, videos, etc appear).

(In reply to avlas from comment #7)
> (In reply to Stefano Crocco from comment #6)
> > (In reply to avlas from comment #5)
> > > I think the main problem is that adblock does not work in WebEngine, it only
> > > works in WebKit as far as I can tell
> > 
> > To be more precise, it also works in WebEngine, but for images only. I don't
> > know whether there was a specific reason to restrict it to images only
> > (maybe for performance). In any case, even on WebKit, Konqueror supports
> > only the most basic features of AdBlock. I'm woking on improving this, but
> > it means rewriting the AdBlock engine, so it's not easy.
> 
> Thanks for your work, Stefano, it's very appreciated!
> 
> Regarding adblock images in WebEngine, how does it work exactly? Does it
> mean images of ads should not be displayed? I'm not sure it is a bug or
> something but this doesn't work in my end, for instance here
> https://www.ccma.cat/esport3 (sometimes it seems to work once but refreshing
> makes all images, videos, etc appear).

I tried loading the site you mention and, enabling all automatic filters, only one image was blocked: 
https://tpc.googlesyndication.com/generate_204?DBDfQw

The way it should work is that images displayed in an <img> html element and which match one of the enabled filters are blocked. Images displayed in other ways may not be filtered.

I just realized that, for some reason, the list of automatic filters in the adblock configuration page is completely empty, meaning you can't use any of the predefined lists that can be found online and you're forced to manually create your own filters. I don't know why and when this happened (I don't think it was intentional), but I'll try to fix this issue.