Bug 456619 - Greyed-Out Edit Clip on Duplicated TItle Clip
Summary: Greyed-Out Edit Clip on Duplicated TItle Clip
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 22.04.3
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: erjiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 10:48 UTC by Stephen Esseenyne
Modified: 2022-07-19 04:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Esseenyne 2022-07-12 10:48:40 UTC
SUMMARY
Greyed-out Edit on Duplicated Title Clip.

STEPS TO REPRODUCE
1. Right click on a title clip
2. Duplicate Clip
3. Right clip on duplicated clip

OBSERVED RESULT
Greyed-out Edit Clip

EXPECTED RESULT
Edit Clip enabled.

SOFTWARE/OS VERSIONS

Windows 10 Version 2009 (x86_64)

KDE Frameworks Version: 5.95.0

Qt Version: 5.15.5 (build against5.15.5)

ADDITIONAL INFORMATION

MLT 7.9.0
Comment 1 erjiang 2022-07-13 05:29:14 UTC
Confirmed, looks like when the "Edit Clip" item's enabled state is updated, the clip is not ready. Because the clip is not ready, its thought to be ClipType::Unknown instead of ClipType::Text, so "Edit Clip" is disabled.
Comment 2 Bug Janitor Service 2022-07-13 05:34:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kdenlive/-/merge_requests/326
Comment 3 Jean-Baptiste Mardelle 2022-07-13 07:32:49 UTC
Git commit 505983e529c80ba5c8a13dd0a02ff949f7530873 by Jean-Baptiste Mardelle, on behalf of Eric Jiang.
Committed on 13/07/2022 at 06:57.
Pushed by mardelle into branch 'master'.

Don't wait for a clip to be ready to get its type

This fixes a bug where after duplicating a title clip, the context
menu's "Edit Clip" action is disabled because the clip's type is thought
to be Unknown.

M  +4    -1    src/bin/bin.cpp

https://invent.kde.org/multimedia/kdenlive/commit/505983e529c80ba5c8a13dd0a02ff949f7530873
Comment 4 Jean-Baptiste Mardelle 2022-07-13 11:39:17 UTC
Git commit d9d2d81efd98061873cbfbba75e6ee727b8de7f4 by Jean-Baptiste Mardelle, on behalf of Eric Jiang.
Committed on 13/07/2022 at 11:38.
Pushed by mardelle into branch 'release/22.08'.

Don't wait for a clip to be ready to get its type

This fixes a bug where after duplicating a title clip, the context
menu's "Edit Clip" action is disabled because the clip's type is thought
to be Unknown.

M  +4    -1    src/bin/bin.cpp

https://invent.kde.org/multimedia/kdenlive/commit/d9d2d81efd98061873cbfbba75e6ee727b8de7f4
Comment 5 erjiang 2022-07-19 04:46:52 UTC
Seems like this fix uncovers another issue - the clip monitor is not switched to the new duplicate clip: https://invent.kde.org/multimedia/kdenlive/-/commit/505983e529c80ba5c8a13dd0a02ff949f7530873#note_488366