Bug 456618 - Searching with the name of a desktop effect doesn't always lead to the desktop effects applet in system settings
Summary: Searching with the name of a desktop effect doesn't always lead to the deskto...
Status: CONFIRMED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.25.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-07-12 10:45 UTC by burak.yncr.4444
Modified: 2022-07-13 20:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description burak.yncr.4444 2022-07-12 10:45:30 UTC
SUMMARY
When using the main search box of system settings, typing the name of a desktop effect sometimes leads to the desktop effects applet, while sometimes it doesn't. For example, searching for "Wobbly Windows" takes you to the applet, "Magic Lamp" takes you to the applet, however "Squash" doesn't even though magic lamp does. Typing the name of a third party desktop effect never leads to the applet.
The reason this happens is probably because there isn't a dynamic list of desktop effects. All the keywords for KWin effects kcm are hard coded in the KWin sources, specifically the following file: https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwineffects/metadata.json 
A possible solution is to dynamcally generate a list of installed effects, by querying /usr/share/kwin/effects and /usr/share/kwin/desktop-effects, as well as their ~/.local/share counterparts, and use that list plus the other defined keywords in Systemsettingsrunner::setupMatch function.
STEPS TO REPRODUCE
1. Search for a desktop effect that is not in the KCM's keyword list

OBSERVED RESULT
1. The user is not directed to kwin-effects kcm applet.

EXPECTED RESULT
1. The user should be directed to kwin-effects kcm applet.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
Operating System: Arch Linux
KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.18.10-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-3230M CPU @ 2.60GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 4000
Manufacturer: Micro-Star International Co., Ltd.
Product Name: GE60 0NC\0ND
System Version: REV:1.0

ADDITIONAL INFORMATION
Link to the KWin effects kcm source code: https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwineffects/
Link to the KWin effects kcm metadata file: https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwineffects/metadata.json
Link to systemsettingsrunner.cpp: https://invent.kde.org/plasma/systemsettings/-/blob/master/runner/systemsettingsrunner.cpp
Comment 1 Nate Graham 2022-07-13 19:23:50 UTC
Yes, that's a correct understanding of the problem and a potential solution. Would you like to try implementing it?
Comment 2 burak.yncr.4444 2022-07-13 20:21:00 UTC
(In reply to Nate Graham from comment #1)
> Yes, that's a correct understanding of the problem and a potential solution.
> Would you like to try implementing it?

Thanks for confirming. I will give it a try.