Bug 456591 - No warning when delete folder not empty
Summary: No warning when delete folder not empty
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Trash (other bugs)
Version First Reported In: 7.6.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-11 15:47 UTC by Antonio
Modified: 2022-07-17 11:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio 2022-07-11 15:47:09 UTC
SUMMARY
***
No warning when one attempts to delete a folder still containing images.
***


STEPS TO REPRODUCE
1. From floders tree, select a folder
2. Right+click >Delete album

OBSERVED RESULT
The album is deleted without any warning in case it still contains images.

EXPECTED RESULT
The panel, asking if we want complete delete the folder or only move to the basket, should also warn the user in case the deleting folder still contains files.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 20.04.4 LTS
Comment 1 Maik Qualmann 2022-07-11 18:28:08 UTC
If you right-click on an album, you can see whether there are images in the view.
Then comes the dialog that asks again. If you delete without the trash, a warning message will appear again if there are files that may not have been displayed in digiKam. If you delete in the trash, there is even an undo function. I don't think we need any more warnings here as deleting not empty albums is intentional for most users.

Maik
Comment 2 Maik Qualmann 2022-07-17 11:05:23 UTC
Git commit 20a81964dc3f7cc297b7c347c3e62b85c889d353 by Maik Qualmann.
Committed on 17/07/2022 at 11:04.
Pushed by mqualmann into branch 'master'.

add extra dialog when deleting an album that is not empty
FIXED-IN: 8.0.0

M  +2    -1    NEWS
M  +20   -3    core/libs/album/engine/albummodificationhelper.cpp

https://invent.kde.org/graphics/digikam/commit/20a81964dc3f7cc297b7c347c3e62b85c889d353