Bug 456487 - Color Schemes' inactive titlebars are now always tinted with the accent color even when the rest of the window is not tinted with the accent color
Summary: Color Schemes' inactive titlebars are now always tinted with the accent color...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 5.25.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-07-08 18:25 UTC by The Feren OS Dev
Modified: 2022-07-17 15:21 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description The Feren OS Dev 2022-07-08 18:25:49 UTC
SUMMARY
Colour Schemes that have Apply Accent To Inactive Titlebars turned OFF still get inactive titlebars tinted even though they're not configured to tint at all, and literally have the option for colour overriding in inactive titlebars off.

Suffice to say, this leads to undesirable results like this: https://i.imgur.com/eKohgym.png

(while the screenshot was taken from a modded Colors KCM, I've also reproduced it in KDE neon without modifications)


STEPS TO REPRODUCE
1. Edit a Colour Scheme to have active titlebar colouring on, inactive titlebar colouring off, and tinting completely off
2. Save the changes
3. Apply your new colour scheme
3.alt: Alternatively, just apply Breeze Classic

OBSERVED RESULT
Inactive titlebars are tinted

EXPECTED RESULT
Inactive titlebars are left unmodified from how they are in the colour scheme itself

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon 5.25.2
(available in About System)
KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2022-07-13 18:36:47 UTC
Based on the code, I see that this is intentional, and the option to not tint inactive titlebars was removed from Plasma 5.26.

I don't see a visual problem in the screenshot; can you explain it?
Comment 2 The Feren OS Dev 2022-07-14 19:46:38 UTC
(In reply to Nate Graham from comment #1)
> Based on the code, I see that this is intentional, and the option to not
> tint inactive titlebars was removed from Plasma 5.26.
> 
> I don't see a visual problem in the screenshot; can you explain it?

Basically, some themes are designed where the titlebar becomes the background of the toolbar below it when inactive, to better emphasise that they're inactive windows (and increase contrast between active and inactive windows).

Suffice to say, with tinting on them like that, it can also look rather off-putting (given the lack of tinting right below it, as if it's an unintentional change the colour scheme's designer did not expect), and adds overall design inconsistency with how the titlebar looks if the user isn't using accent colours whatsoever (given the aforementioned theme design).

Sure, the minor tinting is a good idea for inactive windows, but the option being there initially was ultimately done to avoid the aforementioned design situation.
Comment 3 Nate Graham 2022-07-14 19:49:10 UTC
I guess we should only have it do this when the rest of the window is also being tinted in the same way. I think it was done to fix that case, because it looked odd otherwise. But we need to handle both cases.
Comment 4 The Feren OS Dev 2022-07-17 15:21:12 UTC
Turns out this was fixed in .3 by https://invent.kde.org/plasma/plasma-workspace/-/commit/00a18a8c5aeb6c0b4e2b157dec11e4e1032d20cd, thus this is now RESOLVED.