Bug 456447 - Dolphin clears filter when pressing "Back" after opening a folder from the filtered list
Summary: Dolphin clears filter when pressing "Back" after opening a folder from the fi...
Status: ASSIGNED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: filter (show other bugs)
Version: 22.04.2
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Frédéric Lachapelle
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-07-07 12:20 UTC by postix
Modified: 2023-01-25 18:02 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2022-07-07 12:20:51 UTC
STEPS TO REPRODUCE
1. Open Dolphin
2. Open the filter (ctrl + i) and filter for some search term
3. Open a folder from the filtered list
4. Press "back" (eg the `back` button on your mouse)

OBSERVED RESULT
Dolphin clears the filter and shows all files and folders again.

EXPECTED RESULT
Dolphin keeps the filter used before.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220705
KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
Comment 1 Nate Graham 2022-07-13 18:18:08 UTC
Can confirm, this is slightly annoying.
Comment 2 Frédéric Lachapelle 2022-07-15 17:48:38 UTC
I'm not sure of the change you want to be implemented (Sorry in advance, I am a new KDE Developer). There is a lock next to the filter to keep the filter when switching folders. Is the lock not a good solution (easy to miss?) and instead always keep the filter (remove the lock?). Thank you!
Comment 3 postix 2022-07-15 18:01:07 UTC
Following scenario:

1) You look for (a) particular folder(s) and therefore filter your items
2) Then you open one of the folder to do something and 
3) go back to your filtered list without needing to enter the same filter string again

So for my usecase it'd good if the filter was cleared on entering a folder from a filtered folder list, but is reset to the filter value when going back, i.e. hitting the "back / <--" button.
Comment 4 postix 2022-07-15 18:02:43 UTC
>  Is the lock not a good solution (easy to miss?) 
The lock keeps the filter always on and as such is not suitable for my workflow. :)

> I am a new KDE Developer
Welcome! \o/
Comment 5 Frédéric Lachapelle 2022-08-28 08:29:45 UTC
I've been working on this today, and I've been able to make it happen. I have some work to do to clean up the code (I made a bit of a mess), then I will proceed to make my first MR for KDE :)

Here's a video of what it looks like:

https://streamable.com/g7sxnu
Comment 6 Nicolas Fella 2022-08-28 20:22:23 UTC
So basically you want the filter to be remembered on a per-folder basis? Surely then it should also be remembered when clicking on the folder in the URL bar, not only when pressing the back button?
Comment 7 Frédéric Lachapelle 2022-08-28 22:09:21 UTC
(In reply to Nicolas Fella from comment #6)
> So basically you want the filter to be remembered on a per-folder basis?
> Surely then it should also be remembered when clicking on the folder in the
> URL bar, not only when pressing the back button?

Personnally, it would only make sense on a back. When pressing back, you should recover your previous state. But when clicking on a folder, you're assuming you're going to a new state.  I feel like remembering filters on a per-folder basis, no matter how the folders are accessed, is a different feature entirely.