Bug 456359 - Ctrl-W should be closing a currently shown tab, not the entire book
Summary: Ctrl-W should be closing a currently shown tab, not the entire book
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: ux-ui (show other bugs)
Version: git (master)
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-05 15:52 UTC by Dawid Wróbel
Modified: 2024-12-19 10:04 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/office/kmymoney/-/commit/391652ab5f620dfa3599f82f4638be17ab489e4f
Version Fixed In: 5.2
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Wróbel 2022-07-05 15:52:49 UTC 
SUMMARY
Now that the app supports showing multiple tabs in a view, Ctrl-W shortcut should be closing a currently shown tab, which is what is commonly expected of that shortcut, instead of the while book (file).

STEPS TO REPRODUCE
1. Open multiple tabs, e.g. in ledger view
2. Hit Ctrl-W

OBSERVED RESULT
The whole book is closed

EXPECTED RESULT
The currently-shown tab should be closed
Comment 1 Thomas Baumgart 2022-07-10 08:52:22 UTC 
Git commit 391652ab5f620dfa3599f82f4638be17ab489e4f by Thomas Baumgart.
Committed on Sun Jul 10 10:29:39 2022 +0200
Pushed by tbaumgart into branch 'master'.

    The close shortcut closes tabs first then the file
    
    In the views that allow to open multiple tabs at once (ledger and
    reports) hitting the Close shortcut (Ctrl+W) will close the current
    selected tab and not the whole file. If the current view does not have
    any closable tabs, the file will be closed as before.