Bug 455925 - plasma indicator:draws tasks assets for applet focus indicators instead of plasma tabbar
Summary: plasma indicator:draws tasks assets for applet focus indicators instead of pl...
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-25 16:55 UTC by doncbugs
Modified: 2022-07-05 06:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
2 assets drawn at same time (18.04 KB, image/png)
2022-06-25 16:56 UTC, doncbugs
Details
Multiple tabbars drawn for system tray (4.00 KB, image/png)
2022-06-26 19:22 UTC, doncbugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doncbugs 2022-06-25 16:55:55 UTC
SUMMARY
It looks like 2 different svgs are being drawn at the same time for the focus indicator on applets. Kickoff, the system tray, and the clock all appear to have this problem. When the assets look different, it can be rather ugly.


STEPS TO REPRODUCE
1. Use a Plasma theme with distinct designs for tabbar and tasks (focus), I used Willow Dark
2. Open the system tray or Kickoff in latte-dock
3. 

OBSERVED RESULT
The tasks asset (the part that looks stretched) and the tabbar asset (the light blue line) are drawn on top of each other.

EXPECTED RESULT
Either the tasks asset or the tabbar asset are drawn, but not both. I would prefer consistency with Plasma and choose the tabbar asset.

Operating System: KDE neon Testing Edition
KDE Plasma Version: 5.25.1
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.13.0-51-generic (64-bit)
Graphics Platform: X11
Comment 1 doncbugs 2022-06-25 16:56:33 UTC
Created attachment 150150 [details]
2 assets drawn at same time

The Willow Dark theme demonstrating tasks and tabbar in use.
Comment 2 Michail Vourlakos 2022-06-25 18:25:15 UTC
1. are you sure you are using git version?
2. tell me a plasma theme to test this
Comment 3 doncbugs 2022-06-25 23:45:13 UTC
(In reply to Michail Vourlakos from comment #2)
> 1. are you sure you are using git version?
Yes, this was to test the blur mask fix. It is performed on a live USB.
> 2. tell me a plasma theme to test this
It's in the "Steps to reproduce" and the attachment. Search "wilow dark" in plasma themes or get it from here: https://store.kde.org/p/1563375/
Comment 4 Michail Vourlakos 2022-06-26 05:25:09 UTC
(In reply to doncbugs from comment #1)
> Created attachment 150150 [details]
> 2 assets drawn at same time
> 
> The Willow Dark theme demonstrating tasks and tabbar in use.

what are the two assets drawn in this screenshot? I dont see any....
Comment 5 Michail Vourlakos 2022-06-26 06:20:31 UTC
Git commit 46f343aa5cf1aecb0b7b0f303c8859fcc78b4c02 by Michail Vourlakos.
Committed on 26/06/2022 at 06:15.
Pushed by mvourlakos into branch 'master'.

plasma_indicator:respect plasma theme svgs

--use plasma implementation for plasma applets and tasks
at all cases... all workarounds must be removed and respect
plasma themes even when they are broken on their
implementation.

M  +4    -4    indicators/org.kde.latte.plasma/package/config/config.qml
A  +44   -0    indicators/org.kde.latte.plasma/package/ui/AppletBackLayer.qml     [License: GPL(v2.0+)]
M  +5    -14   indicators/org.kde.latte.plasma/package/ui/BackLayer.qml
M  +32   -5    indicators/org.kde.latte.plasma/package/ui/main.qml

https://invent.kde.org/plasma/latte-dock/commit/46f343aa5cf1aecb0b7b0f303c8859fcc78b4c02
Comment 6 Michail Vourlakos 2022-06-26 06:21:13 UTC
should be fixed, you can check it out...
Comment 7 doncbugs 2022-06-26 19:22:40 UTC
Created attachment 150172 [details]
Multiple tabbars drawn for system tray

It looks mostly fixed.

I think this is a feature you added. The system tray draws 2 tabbars? One for the whole system tray and one for the applet. I think it should stick to the plasma panel way and only draw the one. It works for the Breeze style, but it makes other styles look weird.

The screenshot is made by clicking the system tray arrow.
Comment 8 Michail Vourlakos 2022-06-26 20:34:05 UTC
(In reply to doncbugs from comment #7)
> Created attachment 150172 [details]
> Multiple tabbars drawn for system tray
> 
> It looks mostly fixed.
> 
> I think this is a feature you added. The system tray draws 2 tabbars? One
> for the whole system tray and one for the applet. I think it should stick to
> the plasma panel way and only draw the one. It works for the Breeze style,
> but it makes other styles look weird.
> 
> The screenshot is made by clicking the system tray arrow.

systray can not be fixed directly is an internal thing in plasma systray implementaion. only thing you can do is use: https://github.com/psifidotos/plasma-systray-latte-tweaks
Comment 9 doncbugs 2022-07-03 22:26:36 UTC
(In reply to Michail Vourlakos from comment #8)

> systray can not be fixed directly is an internal thing in plasma systray
> implementaion. only thing you can do is use:
> https://github.com/psifidotos/plasma-systray-latte-tweaks

I don't understand. The plasma system tray only draws the tabbar.svg on the item that is active (e.g., clipboard, volume, the "hidden icons" arrow/tray). Latte draws tabbar.svg over the whole tray and a second one over the active item. It seems that Latte has changed the behavior of the tray?
Comment 10 Michail Vourlakos 2022-07-04 06:39:09 UTC
(In reply to doncbugs from comment #9)
> (In reply to Michail Vourlakos from comment #8)
> 
> > systray can not be fixed directly is an internal thing in plasma systray
> > implementaion. only thing you can do is use:
> > https://github.com/psifidotos/plasma-systray-latte-tweaks
> 
> I don't understand. The plasma system tray only draws the tabbar.svg on the
> item that is active (e.g., clipboard, volume, the "hidden icons"
> arrow/tray). Latte draws tabbar.svg over the whole tray and a second one
> over the active item. It seems that Latte has changed the behavior of the
> tray?

no its just that the systray is stupid. There is already an open bug for this. But noone can fix it yet. And personally I dont care, I use plasma systray latte tweaks.
Comment 11 doncbugs 2022-07-04 19:10:55 UTC
(In reply to Michail Vourlakos from comment #10)

> no its just that the systray is stupid. There is already an open bug for
> this. But noone can fix it yet.
Can you link the bug?

> And personally I dont care, I use plasma
> systray latte tweaks.
Is it available on the KDE store as a dependency I can use for a global theme?
Comment 12 Michail Vourlakos 2022-07-05 06:38:30 UTC
(In reply to doncbugs from comment #11)
> (In reply to Michail Vourlakos from comment #10)
> 
> > no its just that the systray is stupid. There is already an open bug for
> > this. But noone can fix it yet.
> Can you link the bug?
> 

sorry I can not find it... it somewhere lost in the plasmashell product issues

> > And personally I dont care, I use plasma
> > systray latte tweaks.
> Is it available on the KDE store as a dependency I can use for a global
> theme?

no you can not use it that way, you need to install it manually from: https://github.com/psifidotos/plasma-systray-latte-tweaks
and you need also to update it manually in every new Plasma major release.
Comment 13 Michail Vourlakos 2022-07-05 06:45:14 UTC
(In reply to doncbugs from comment #11)
> (In reply to Michail Vourlakos from comment #10)
> 
> > no its just that the systray is stupid. There is already an open bug for
> > this. But noone can fix it yet.
> Can you link the bug?
> 

found it: https://bugs.kde.org/show_bug.cgi?id=448664