Bug 455920 - Replace InstallTrigger Firefox check
Summary: Replace InstallTrigger Firefox check
Status: CONFIRMED
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: Firefox (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-25 14:25 UTC by Nico
Modified: 2023-02-06 12:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nico 2022-06-25 14:25:53 UTC 
SUMMARY
InstallTrigger check to detect Firefox should be replaced

STEPS TO REPRODUCE
1. Have the addon installed and load a page

OBSERVED RESULT
See console warning:
```
InstallTrigger is deprecated and will be removed in the future. constants.js:50:14
```

EXPECTED RESULT
Should no longer use InstallTrigger to detect Firefox

SOFTWARE/OS VERSIONS
Firefox: 101.0.1 (64-bit)
Plasma Integration: 1.8.1

ADDITIONAL INFORMATION
Comment 1 kt47uo5uvzw 2022-11-03 23:48:46 UTC 
The following line needs to be updated:
https://invent.kde.org/plasma/plasma-browser-integration/-/blob/master/extension/constants.js#L50
Comment 2 kt47uo5uvzw 2022-11-03 23:49:19 UTC 
The following line needs to be updated:
https://invent.kde.org/plasma/plasma-browser-integration/-/blob/master/extension/constants.js#L50
Comment 3 Mario Bašić 2023-02-06 12:09:30 UTC 
I see here https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/75/diffs that there is a fix for this issue, but it seems like the new version of the extension which includes this fix has not been published. 

When will it be published it has been 4 months since this was fixed?

On the same topic, why not implement it like this https://github.com/philc/vimium/commit/c5f232c75ee5fafd95eda456c1db88363902814a ?