Bug 455792 - Feature request: add a close button in the event details pane
Summary: Feature request: add a close button in the event details pane
Status: RESOLVED NOT A BUG
Alias: None
Product: Merkuro
Classification: Applications
Component: general (show other bugs)
Version: 22.04.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Claudio Cambra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-22 15:06 UTC by Riccardo Robecchi
Modified: 2022-06-28 07:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of Calendar (265.87 KB, image/png)
2022-06-22 15:08 UTC, Claudio Cambra
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Riccardo Robecchi 2022-06-22 15:06:06 UTC
SUMMARY
When you click on an event, a pane is opened on the right hand side. To close this pane, however, no "close" button is offered like in every other KDE application (e.g. System Monitor). Adding it would make the UX easier and more consistent with the rest of the experience on desktop-like devices.

STEPS TO REPRODUCE
1. Click on an event to open the details pane

OBSERVED RESULT
The pane has no "close" button.

EXPECTED RESULT
The pane has a "close" button.

SOFTWARE/OS VERSIONS
Linux: KDE neon
KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4

ADDITIONAL INFORMATION
Comment 1 Claudio Cambra 2022-06-22 15:08:59 UTC
Created attachment 150056 [details]
Screenshot of Calendar

Hi Robert, please check the button to the left of the incidence information drawer header -- this is a close button to collapse the right drawer

Additionally, the drawer can be closed by clicking on empty space in the main calendar views
Comment 2 Riccardo Robecchi 2022-06-22 15:12:02 UTC
(In reply to Claudio Cambra from comment #1)
> Created attachment 150056 [details]
> Screenshot of Calendar
> 
> Hi Robert, please check the button to the left of the incidence information
> drawer header -- this is a close button to collapse the right drawer
> 
> Additionally, the drawer can be closed by clicking on empty space in the
> main calendar views

Thanks. The fact that I had never noticed this despite using the software everyday, however, does confirm in my view that more consistency with other KDE software is needed. Would you consider making it a proper "close" button and including it in the pane itself, rather than grouping it with other buttons in the top bar?
Comment 3 Claudio Cambra 2022-06-22 15:38:10 UTC
(In reply to Riccardo Robecchi from comment #2)
> (In reply to Claudio Cambra from comment #1)
> > Created attachment 150056 [details]
> > Screenshot of Calendar
> > 
> > Hi Robert, please check the button to the left of the incidence information
> > drawer header -- this is a close button to collapse the right drawer
> > 
> > Additionally, the drawer can be closed by clicking on empty space in the
> > main calendar views
> 
> Thanks. The fact that I had never noticed this despite using the software
> everyday, however, does confirm in my view that more consistency with other
> KDE software is needed. Would you consider making it a proper "close" button
> and including it in the pane itself, rather than grouping it with other
> buttons in the top bar?

This is the default close action for Kirigami drawers and is in line with other Kirigami applications like Neochat, so it is unlikely we will change this behaviour to be in line with the older QWidgets apps
Comment 4 Riccardo Robecchi 2022-06-28 07:54:13 UTC
(In reply to Claudio Cambra from comment #3)
> This is the default close action for Kirigami drawers and is in line with
> other Kirigami applications like Neochat, so it is unlikely we will change
> this behaviour to be in line with the older QWidgets apps

This doesn't change the fact that the current implementation is very poor from a UX and UI perspective. In Neochat, the button to open the drawer is always there, while in Kalendar is not (it appears out of nothing when you first select an event); in Neochat, it is the only button on the top bar, so it's easy to see it, while on Kalendar it is surrounded by other buttons; in Neochat you can only open the sidebar by clicking on the button, which means that it is straightforward to understand how to close it, while in Kalendar you open the sidebar by clicking on an event, which therefore doesn't make "click on a button that you didn't know existed and which is not in the context of the sidebar in order to close it" exactly clear.
Not a single other application that I know of, in Linux or any other environment, does this and for very good reason. Among other things, it breaks POLA.