SUMMARY Updated smb4k from 3.1.1 to 3.1.2 and received a desktop notification that it does not like its bookmark file anymore. I went ahead and moved it out so i could simply recreate my two entries by creating them again via the application. But starting the application again it had the same problem, turns out it seems to revive a very old and meanwhile incompatible copy still hanging around in my homedir. STEPS TO REPRODUCE 1. killall smb4k; rm .local/share/smb4k/bookmarks.xml; rm .kde4/share/apps/smb4k/bookmarks.xml 2. create .kde4/share/apps/smb4k/bookmarks.xml with contents <?xml version="1.0" encoding="UTF-8"?> <bookmarks version="1.1"> <bookmark profile="" group=""> <workgroup>WORKGROUP</workgroup> <unc>//192.168.1.42/media</unc> <login></login> <ip></ip> <type>Disk</type> <label></label> </bookmark> </bookmarks> 3. smb4k OBSERVED RESULT popup disliking that bookmark file, which the app imported itself, plus in fact that popup for the config i had and which was probably working before EXPECTED RESULT warnings about the outdated config in the "new" place can and should probably stay, when old file is revived it should probably silently skip bookmarks it does not like, or the whole list in case its a "global" thing, or if those old files can not be used for sure ... the revive code should not be exectuted at all SOFTWARE/OS VERSIONS Linux/KDE Plasma: 5.24.5 (available in About System) KDE Plasma Version: 5.24.5 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.4 ADDITIONAL INFORMATION
I did not use smb4k in a very long time, but it starts up with KDE which i use on a daily basis on that machine. Not sure if the bookmarks have been silently missing and only the "popup" is a new thing. That popup is in fact confusing and i wonder why the bookmarks file was not just converted at some point when the old and new format where supported in a version of the application. That is kind of one of two problems. The second is the pointless import of an old version that simply can not work.
Git commit c735be02cd49de6497228194a1dbb639dbbc9ec3 by Alexander Reinholdt. Committed on 03/07/2022 at 08:02. Pushed by areinholdt into branch 'master'. Remove KDE4 migration code. M +1 -70 smb4k/main.cpp https://invent.kde.org/network/smb4k/commit/c735be02cd49de6497228194a1dbb639dbbc9ec3
Git commit 6b486314a19e192de18e39ba28b3692483b23399 by Alexander Reinholdt. Committed on 06/07/2022 at 18:16. Pushed by areinholdt into branch '3.1'. Remove KDE4 migration code. M +2 -93 smb4k/main.cpp https://invent.kde.org/network/smb4k/commit/6b486314a19e192de18e39ba28b3692483b23399