Bug 455753 - Present Windows search bar retains previous search on subsequent openings
Summary: Present Windows search bar retains previous search on subsequent openings
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-present-windows (show other bugs)
Version: 5.25.1
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 455786 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-06-21 21:21 UTC by Mark S
Modified: 2022-06-23 17:17 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark S 2022-06-21 21:21:50 UTC
SUMMARY

When using the Present Windows effect, the search bar retains the previous search/filter query. Prior to 5.25.0 the search query was not retained.

STEPS TO REPRODUCE

1. Use the Present Windows effect (Ctrl+F9 or Ctrl+F10)
2. Type in the search field
3. Close out of the Present Windows effect (via the Escape key or by selecting a window)
4. Reopen the Present Windows effect

OBSERVED RESULT

The previous search query is retained

EXPECTED RESULT

The previous search query is not retained

SYSTEM INFO

Operating System: Arch Linux
KDE Plasma Version: 5.25.1
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
Kernel Version: 5.18.5-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 1 Niklas Stephanblome 2022-06-22 15:06:00 UTC
I already fixed this as part of my merge request that will very soon be merged: https://invent.kde.org/plasma/kwin/-/merge_requests/2562
Comment 2 Nate Graham 2022-06-22 18:54:53 UTC
*** Bug 455786 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2022-06-23 17:14:27 UTC
Git commit 6838b1132fad8b32c26409fd46b2e49803684dd6 by Nate Graham, on behalf of Niklas Stephanblom.
Committed on 23/06/2022 at 17:13.
Pushed by ngraham into branch 'master'.

Windowview: Fix broken keyboard navigation while filtering

After the 5.25 update, one could not see which window was highlighted until one
manually unfocused the SearchField and then pressed any key to refresh the WindowHeap.
Also, the searchbar would (most of the time) "absorb" the arrow keys so one had to
also unfocus it to really be able to select windows with they keyboard. 

With this change, there is always one window highlighted while filtering using the
search box. Also, one can select another window with the arrow keys without manually
unfocusing the searchbox. This heavily improves the keyboard functionality in this
effect that got lost with the 5.25 update of presentwindows to windowview and
resolves complaints about the keyboard navigation being buggy. 
Related: bug 455633, bug 455764, bug 455099, bug 455586
FIXED-IN: 5.25.2

M  +6    -2    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowvieweffect.cpp

https://invent.kde.org/plasma/kwin/commit/6838b1132fad8b32c26409fd46b2e49803684dd6
Comment 4 Nate Graham 2022-06-23 17:17:06 UTC
Git commit dcc77bfa8fbca8032047fbbb5ab65382293488ac by Nate Graham, on behalf of Niklas Stephanblom.
Committed on 23/06/2022 at 17:16.
Pushed by ngraham into branch 'Plasma/5.25'.

Windowview: Fix broken keyboard navigation while filtering

After the 5.25 update, one could not see which window was highlighted until one
manually unfocused the SearchField and then pressed any key to refresh the WindowHeap.
Also, the searchbar would (most of the time) "absorb" the arrow keys so one had to
also unfocus it to really be able to select windows with they keyboard. 

With this change, there is always one window highlighted while filtering using the
search box. Also, one can select another window with the arrow keys without manually
unfocusing the searchbox. This heavily improves the keyboard functionality in this
effect that got lost with the 5.25 update of presentwindows to windowview and
resolves complaints about the keyboard navigation being buggy. 
Related: bug 455633, bug 455764, bug 455099, bug 455586
FIXED-IN: 5.25.2


(cherry picked from commit 6838b1132fad8b32c26409fd46b2e49803684dd6)

M  +6    -2    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowvieweffect.cpp

https://invent.kde.org/plasma/kwin/commit/dcc77bfa8fbca8032047fbbb5ab65382293488ac