Bug 455624 - krunner kcm does not use its translations
Summary: krunner kcm does not use its translations
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (other bugs)
Version First Reported In: 5.25.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Alexander Lohnau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-19 23:23 UTC by Albert Astals Cid
Modified: 2022-07-03 15:35 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2022-06-19 23:23:35 UTC
package/contents/ui/main.qml has i18n calls but they are not being used.

Those calls either need to be i18nd and specify the kcm_search domain manually or some other plasma magic needs to be renamed so they are used.
Comment 1 Albert Astals Cid 2022-06-19 23:24:29 UTC
to be clear when i said package/contents/ui/main.qml i meant plasma-desktop/kcms/runners/package/contents/ui/main.qml
Comment 2 Alexander Lohnau 2022-06-21 18:40:55 UTC
Do you mean plasma-desktop/kcms/runners/plasmasearch/package/contents/ui/main.qml? And also plasma-desktop/kcms/runners/krunner/package/contents/ui/main.qml?
Comment 3 Albert Astals Cid 2022-06-21 21:48:02 UTC
All those paths that you list don't exist in the 5.25 branch as far as i can see
Comment 4 Alexander Lohnau 2022-06-22 05:12:35 UTC
Okay, then this was reported for 5.25 only. Though master has additional issues then.
I will look into making a MR.
Comment 5 Bug Janitor Service 2022-06-22 14:32:57 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/997
Comment 6 Albert Astals Cid 2022-06-22 17:42:30 UTC
(In reply to Alexander Lohnau from comment #4)
> Okay, then this was reported for 5.25 only. Though master has additional
> issues then.
> I will look into making a MR.

I mean I don't know if master has additional issues, it was rewritten yet again it seems so it may have, I don't run master.
Comment 7 Alexander Lohnau 2022-07-01 04:57:46 UTC
Git commit 6ba9ed29774495ee390c169aea34120aa67ed403 by Alexander Lohnau.
Committed on 01/07/2022 at 04:57.
Pushed by alex into branch 'master'.

Adjust translation catalog names for KRunner KCMs

M  +1    -1    kcms/runners/CMakeLists.txt
M  +1    -1    kcms/runners/Messages.sh
C  +1    -1    kcms/runners/krunner/Messages.sh [from: kcms/runners/Messages.sh - 070% similarity]

https://invent.kde.org/plasma/plasma-desktop/commit/6ba9ed29774495ee390c169aea34120aa67ed403
Comment 8 Albert Astals Cid 2022-07-01 15:24:22 UTC
Reopening, Plasma 5.25 is unfixed, given that there's 3 releases still planned would be  to get it fixed there.
Comment 9 Alexander Lohnau 2022-07-03 15:35:44 UTC
Git commit 88f624c0056f90ec307eb7631488b87ddac3021e by Alexander Lohnau.
Committed on 03/07/2022 at 15:31.
Pushed by alex into branch 'Plasma/5.25'.

Fix translation domain for KRunner KCM

It needs to be consistent with the plugin id

M  +3    -1    kcms/runners/Messages.sh

https://invent.kde.org/plasma/plasma-desktop/commit/88f624c0056f90ec307eb7631488b87ddac3021e