Bug 455618 - Panels now ignore Font DPI on X11 with Plasma scaling
Summary: Panels now ignore Font DPI on X11 with Plasma scaling
Status: RESOLVED DUPLICATE of bug 456076
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.25.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-06-19 18:06 UTC by dft
Modified: 2022-07-19 16:07 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
dieseltrike: X11+


Attachments
5.24.5 - You can see icons are bigger in the task manager (19.87 KB, image/jpeg)
2022-06-22 10:13 UTC, dft
Details
5.25 and 5.25.1 (12.86 KB, image/jpeg)
2022-06-22 10:14 UTC, dft
Details
Widened and icons still small - systray scales fine. (36.54 KB, image/jpeg)
2022-06-22 10:16 UTC, dft
Details
Full menu with 5.24.5 and X11 - Look at icon size relative to bar width (17.17 KB, image/jpeg)
2022-07-08 17:19 UTC, dft
Details
Wayland on 125% (16.64 KB, image/jpeg)
2022-07-08 17:22 UTC, dft
Details
X11@125% on 5.25 - Global Scale or DPI makes no dif (12.57 KB, image/jpeg)
2022-07-08 17:23 UTC, dft
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dft 2022-06-19 18:06:43 UTC
Font DPI Scaling works perfectly fine on KDE 5.24.5 but on 5.25 It gets ignored. Icons are all using 96DPI. App still respect DPI of 120 etc but no the Panels. Using Xorg.


STEPS TO REPRODUCE
1.  Update to 5.25
2.  Set Font DPI Scaling to 120
3.  Reboot
4. Icons on Panel haven't scaled at all.

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 dft 2022-06-20 11:32:12 UTC
Faulty version info

KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
Kernel Version: 5.18.5-zen1-1-zen (64-bit)
Graphics Platform: X11

Working version info
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4
Kernel Version: 5.18.3-zen1-1-zen (64-bit)
Graphics Platform: X11
Comment 2 Nate Graham 2022-06-21 18:00:29 UTC
Please attach a screenshot that shows which icons exactly are exhibiting this issue.
Comment 3 dft 2022-06-22 10:13:36 UTC
Created attachment 150044 [details]
5.24.5 - You can see icons are bigger in the task manager
Comment 4 dft 2022-06-22 10:14:57 UTC
Created attachment 150045 [details]
5.25 and 5.25.1

The icons never get "bigger" than shown even if I widen panel. They are the same size as DPI @ 96 even though I'm using 120.
Comment 5 dft 2022-06-22 10:16:13 UTC
Created attachment 150046 [details]
Widened and icons still small - systray scales fine.
Comment 6 David Edmundson 2022-06-22 11:09:50 UTC
After running "plasmashell --replace" from krunner are things right?

If so that implies plasmashell starts before the krdb value is written out properly.
Comment 7 Nate Graham 2022-06-22 15:25:19 UTC
I bet that's what's happening. It could also be the root cause of Bug 449212 too. For that, restarting plasmashell does indeed fix the issue for me.
Comment 8 dft 2022-06-22 16:47:52 UTC
(In reply to David Edmundson from comment #6)
> After running "plasmashell --replace" from krunner are things right?
> 
> If so that implies plasmashell starts before the krdb value is written out
> properly.

My I reboot after that? I ran "plasmashell --replace" from krunner, panels disappeared and sadly icons are still small. I tested on both Wayland and Xorg. 

I have currently held back 5.25 plasma-desktop via pacman.conf so can go back and forth easily.
Comment 9 dft 2022-06-22 16:49:31 UTC
(In reply to dft from comment #8)
> (In reply to David Edmundson from comment #6)
> > After running "plasmashell --replace" from krunner are things right?
> > 
> > If so that implies plasmashell starts before the krdb value is written out
> > properly.
> 
> My I reboot after that? I ran "plasmashell --replace" from krunner, panels
> disappeared and sadly icons are still small. I tested on both Wayland and
> Xorg. 
> 
> I have currently held back 5.25 plasma-desktop via pacman.conf so can go
> back and forth easily.

Poorly worded reply... must I reboot after that? Panels briefly disappeared and then reappeared but looking the same, ie small icons. Restoring 5.24.5 of plasma-desktop looks correct.
Comment 10 dft 2022-07-03 08:49:11 UTC
Updated to 5.25.2 of plasma-desktop - bug is still there it ignores font dpi scaling on taskmanager. Running plasamashell --replace from cli

shows this

file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:220:21: QML SelectableLabel: Binding loop detected for property "implicitWidth"
file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:220:21: QML SelectableLabel: Binding loop detected for property "implicitWidth"
file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:220:21: QML SelectableLabel: Binding loop detected for property "implicitHeight"

Not sure if it's related.
Comment 11 dft 2022-07-03 08:55:22 UTC
Rolling back the package to 5.24.5 and rebooting instantly fixes the icon scaling in task panel
Comment 12 Nate Graham 2022-07-05 15:33:11 UTC
Those binding loops should be unrelated.

I can reproduce the issue on X11 when using (default) Plasma scaling, not Qt scaling. But I'm not sure it's worth fixing since using the font DPI setting to approximate full-screen scaling is explicitly unsupported. That said, while the global scaling slider in System Settings > Display and Monitor will do the right thing on Wayland, it won't do the right thing on X11 because the Panel thickness does not respect it when using Plasma scaling rather than Qt scaling.

So I think we have two paths forward here:
1. Investigate and fix the bug
2. Move forward with making Qt scaling the default on X11 so that the Global Scale slider affects the Panel (as expected, and as it already does on Wayland)
Comment 13 dft 2022-07-06 10:00:57 UTC
The only reason I don't use Global Scaling is all my windows and text gets blurry. I know it's the "recommended" way as the tooltip says but using Font DPI is the only way I get crisp sharp windows, icons and fonts.
Comment 14 dft 2022-07-06 10:16:50 UTC
I have also just tested the latest plasma-desktop with wayland and global scaling and it has the exact same bug. Icons on the panel do not scale. I set a global scale of 125%, rebooted. Icons are small. Then I ran plasmashell --replace and the same thing, icons are small. So this bug appears on both Wayland and XOrg as well as Font DPI and Global Scaling according to my tests.
Comment 15 Nate Graham 2022-07-06 15:33:43 UTC
That doesn't make any sense, unless you're hitting the bug that Wayland doesn't  inherit the scale properly on X11. Which is likely. So let's work around it: when you're in the Wayland session, please try to set the scale back to 100%, and then set it to 125%, then restart plasmashell manually with `plasmashell --replace` in a terminal window. You should see that the panel respects the scale factor and is 125% the thickness it was before.
Comment 16 dft 2022-07-08 17:19:48 UTC
Created attachment 150484 [details]
Full menu with 5.24.5 and X11 - Look at icon size relative to bar width
Comment 17 dft 2022-07-08 17:22:35 UTC
Created attachment 150485 [details]
Wayland on 125%

5.25.2 Icons never get larger than shown. Compare this with 5.24.5 and icons fill more of panel. I have to change to 150% before icons get the same size as they do with 5.24.5 @ 125%. Though Wayland@150% then makes everthing else super big
Comment 18 dft 2022-07-08 17:23:12 UTC
Created attachment 150486 [details]
X11@125% on 5.25 - Global Scale or DPI makes no dif
Comment 19 dft 2022-07-08 18:09:48 UTC
(In reply to Nate Graham from comment #15)
> That doesn't make any sense, unless you're hitting the bug that Wayland
> doesn't  inherit the scale properly on X11.

Definitely hit that bug but it still doesn't scale like X11 in terms of icon size. I have made 4 short yt clips that can hopefully help. I don't run wayland as I currently have too many bugs with it and haven't had a chance to log them all. A few are evident in the video though (Start button keeps opening Anydesk, Search cancel in settings, flicker etc).

https://youtu.be/v-UDF2NJQ1o
Shows the bug in full with X11 5.24.5 vs 5.25.2 of plasma-desktop

https://youtu.be/VmQeay-LYiM
Shows how with X11 changing Global Scale (GS) also changes font dpi (Wayland does not do this) - Also shows no bug with the menu when clearing "search text" in this case "font". On my wayland video I have to press cancel / back twice.

https://youtu.be/dF46BUTrgko
Shows the bug in it's entirety as well as showing there's no bug in clicking "start" menu compared to Wayland.

https://youtu.be/582Abwqu368
Wayland - shows doesn't scale like 5.24.5 X11 also shows blurry text and that changing GS doesn't change dpi like X11 does (Could be by design just something I noticed). Also shows "start" menu bug that keeps opening an app which doesn't even have an icon.
Comment 20 Nate Graham 2022-07-12 19:50:09 UTC
Thanks for the videos, they're quite helpful.


(In reply to dft from comment #19)
> https://youtu.be/v-UDF2NJQ1o
> Shows the bug in full with X11 5.24.5 vs 5.25.2 of plasma-desktop
I think see the problem now. With 5.25 applied, do the panel icons get bigger if you make the panel thicker?


> https://youtu.be/582Abwqu368
> Wayland - shows doesn't scale like 5.24.5 X11 also shows blurry text and
> that changing GS doesn't change dpi like X11 does (Could be by design just
> something I noticed). Also shows "start" menu bug that keeps opening an app
> which doesn't even have an icon.
In this video, the panel thickness changes when you change the scale factor, which is the way it's supposed to be. So there is no panel bug there.
Comment 21 dft 2022-07-18 15:03:35 UTC
Please see https://youtu.be/VgLQ0jX4g7Q - Taken with Xorg. 62 Panel width is the minimum I can select before system tray changes to "singular"

So yes icons do resize on both 5.24 and 5.25 but I think the MAX size is being capped sooner on 5.25. 

With regards to your second question 
"which is the way it's supposed to be. So there is no panel bug there." I think the bug still applies look at the relationship between icon size and panel width. Also for me using Wayland and GS isn't an option at all as it appears KDE is merely resizing a lower res image hence the pixelated text (https://youtu.be/582Abwqu368?t=8) Look at the title bars.

So it makes the panel and icons bigger but not in the same ratio 5.24 did. Again, I think setting the "max size" for icons on taskbar has changed and would fix this.

I would imagine this is some sort of constant in the code and changed after 5.24.
Comment 22 Nate Graham 2022-07-19 16:07:14 UTC
> So yes icons do resize on both 5.24 and 5.25 but I think the MAX size is being capped sooner on 5.25. 
Yeah, and that was an intentional change in Plasma 5.25, which makes this a duplicate of Bug 456076.

*** This bug has been marked as a duplicate of bug 456076 ***