Bug 455588 - Bing POTD doesn't update correctly if it's set to both desktop and lock screen
Summary: Bing POTD doesn't update correctly if it's set to both desktop and lock screen
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: 5.25.0
Platform: Android Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-19 07:21 UTC by Matej Mrenica
Modified: 2022-09-23 01:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2022-06-19 07:21:20 UTC
STEPS TO REPRODUCE
1. Set desktop wallpaper to Bing POTD
2. Set lock screen wallpaper to Bing POTD
3. wait 24 hours (or less)

OBSERVED RESULT
Lock screen wallpaper is updated, desktop wallpaper is not.

EXPECTED RESULT
Both are updated.

SOFTWARE/OS VERSIONS
Arch Linux, everything up-to-date.
Comment 1 Matej Mrenica 2022-06-19 07:23:03 UTC
Currently I set Bing POTD only to my desktop and will see if It updates tomorrow.
Comment 2 Fushan Wen 2022-06-19 09:51:43 UTC
Hi, there could be some bugs in 5.25.0. I have pushed some fixes to 5.25.1, and it works here on both the desktop and the lock screen. 

Please test once 5.25.1 is released (expected tomorrow) to see if the bug is fixed. Sorry for the inconvenience!
Comment 3 Matej Mrenica 2022-06-22 16:18:14 UTC
I am on Plasma 5.25.1 now and this issue isn't fixed. I just noticed that my lock screen and desktop wallpapers are different even though both are set to Bing potd. Setting the wallpaper to something else and back updates the wallpaper but I bet tomorrow it won't update.
Comment 4 Fushan Wen 2022-06-23 01:12:05 UTC
Git commit 27e41d0b8f2c0460a04eb21d0eee92b8c04f3369 by Fushan Wen.
Committed on 23/06/2022 at 01:09.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: shorten update interval if one provider fails to update

M  +16   -8    wallpapers/potd/plugins/potdengine.cpp
M  +4    -3    wallpapers/potd/plugins/potdengine.h

https://invent.kde.org/plasma/kdeplasma-addons/commit/27e41d0b8f2c0460a04eb21d0eee92b8c04f3369
Comment 5 Fushan Wen 2022-06-23 01:12:13 UTC
Git commit 2e2ab2a3f86692cc7d33ee54b5a0de521016fc44 by Fushan Wen.
Committed on 23/06/2022 at 01:09.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: always force update after resume from sleep

To work around some computers don't update the system date immediately.

M  +2    -11   wallpapers/potd/plugins/potdengine.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/2e2ab2a3f86692cc7d33ee54b5a0de521016fc44
Comment 6 Fushan Wen 2022-06-23 01:13:11 UTC
Git commit e35703d6c30f55c40749de89cc50842224ac4b54 by Fushan Wen.
Committed on 23/06/2022 at 01:13.
Pushed by fusionfuture into branch 'Plasma/5.25'.

wallpapers/potd: shorten update interval if one provider fails to update


(cherry picked from commit 27e41d0b8f2c0460a04eb21d0eee92b8c04f3369)

M  +16   -8    wallpapers/potd/plugins/potdengine.cpp
M  +4    -3    wallpapers/potd/plugins/potdengine.h

https://invent.kde.org/plasma/kdeplasma-addons/commit/e35703d6c30f55c40749de89cc50842224ac4b54
Comment 7 Fushan Wen 2022-06-23 01:13:38 UTC
Git commit 4bc4583508b39f229a540aff96bab6f93f4fa263 by Fushan Wen.
Committed on 23/06/2022 at 01:13.
Pushed by fusionfuture into branch 'Plasma/5.25'.

wallpapers/potd: always force update after resume from sleep

To work around some computers don't update the system date immediately.


(cherry picked from commit 2e2ab2a3f86692cc7d33ee54b5a0de521016fc44)

M  +2    -11   wallpapers/potd/plugins/potdengine.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/4bc4583508b39f229a540aff96bab6f93f4fa263
Comment 8 Fushan Wen 2022-06-24 00:56:06 UTC
I can see a cause to fail to update the wallpaper. After resume from sleep, the network connection could be still disconnected, but the provider has started updating wallpapers, and it will get  a network error. But after this change, the provider should be able to update again 10 minutes later.
Comment 9 Fushan Wen 2022-09-23 01:05:09 UTC
Should be fixed in 5.26