Bug 455548 - white artifacts around rounded corners when using dark theme (similar to korners bug) + when animating
Summary: white artifacts around rounded corners when using dark theme (similar to korn...
Status: RESOLVED UPSTREAM
Alias: None
Product: lattedock
Classification: Unmaintained
Component: application (other bugs)
Version First Reported In: 0.10.8
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-18 12:11 UTC by Felix Fischer
Modified: 2022-07-04 06:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Video of the dock in motion, corners can be seen on bottom & top dock (1.72 MB, video/mp4)
2022-06-18 12:11 UTC, Felix Fischer
Details
same tests as in first video with contrast effect disabled (1.59 MB, video/mp4)
2022-06-18 12:26 UTC, Felix Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Fischer 2022-06-18 12:11:30 UTC
Created attachment 149888 [details]
Video of the dock in motion, corners can be seen on bottom & top dock

SUMMARY
When using a dark theme (Breeze dark with accent color tint in my case) and looking at a dock with rounded corners in front of a dark background, you notice a couple of white pixels outside the corner radius. Similarly, when the dock is moving (i.e. because of the parabolic effect or when auto-hiding) white can be seen on the leading edge, so when animating up from the bottom of the screen (previously hidden) a strip of white is in front.


STEPS TO REPRODUCE
1. Install latest version of latte dock (on arch community/latte-dock 0.10.8-1)
2. set up 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Felix Fischer 2022-06-18 12:23:19 UTC
Messed up and accidentally pressed enter before finishing the bug report, so I'll post the rest here (can't find a way to edit original post).

STEPS TO REPRODUCE
1. Install latest version of latte dock (on arch community/latte-dock 0.10.8-1)
2. set up dock with rounded corners using dark theme in front of dark background
3. inspect corners and move dock (auto-hide)

OBSERVED RESULT
White edges when moving, white pixels just outside the rounded corners

EXPECTED RESULT
Dock animates "in one piece" and rounded corners are clean

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux latest stable packages
(available in About System)
KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4

ADDITIONAL INFORMATION
I can confirm that this is caused by the contrast effect, as disabling it in Desktop Effects removes both problems. I believe it could be solved by shrinking the mask for the contrast effect a bit, so there is a small margin for error.
Comment 2 Felix Fischer 2022-06-18 12:26:03 UTC
Created attachment 149889 [details]
same tests as in first video with contrast effect disabled
Comment 3 Michail Vourlakos 2022-06-19 05:24:28 UTC
1. show me a plasma panel with corners, dont you have the same issue?
2. during moving nothing can be done, your system probably can not catch up...
Comment 4 Felix Fischer 2022-06-19 11:37:40 UTC
1. You're right, when using a floating plasma panel I can see exactly the same
2. The reason I was experiencing the issue just now is that I switched back to breeze from layan (https://github.com/vinceliuice/Layan-kde) which does not show any of what I described (also not on the plasma panel)
3. I doubt that the issue with the animations is my system. It certainly is not the fastest, but I run a Ryzen 5 3600 and a Radeon RX 5500XT, so if a faster computer is required in order to run latte smoothly, that would mean everyone would need a high end pc. 

What could be done differently in layan that it does not show any of the issues?
Comment 5 Michail Vourlakos 2022-06-19 14:45:45 UTC
(In reply to Felix Fischer from comment #4)
> 1. You're right, when using a floating plasma panel I can see exactly the
> same
> 2. The reason I was experiencing the issue just now is that I switched back
> to breeze from layan (https://github.com/vinceliuice/Layan-kde) which does
> not show any of what I described (also not on the plasma panel)
> 3. I doubt that the issue with the animations is my system. It certainly is
> not the fastest, but I run a Ryzen 5 3600 and a Radeon RX 5500XT, so if a
> faster computer is required in order to run latte smoothly, that would mean
> everyone would need a high end pc. 
> 
> What could be done differently in layan that it does not show any of the
> issues?

the problem is probably your theme in use...
the mask that is providing does not take into account antialiasing cases. the mask provided should be 1px. narrower from the actual transparent area. this is the way plasma dialogs are solving the case.

> 3. I doubt that the issue with the animations is my system. It certainly is
> not the fastest, but I run a Ryzen 5 3600 and a Radeon RX 5500XT, so if a
> faster computer is required in order to run latte smoothly, that would mean
> everyone would need a high end pc. 

if someone wants blur area that is able to move around flowlessly then it needs a high end pc and in some cases that also might not be enough... kwin disables blur during moving windows for the exact same reason.
Comment 6 Felix Fischer 2022-06-19 15:03:40 UTC
> if someone wants blur area that is able to move around flowlessly then it
> needs a high end pc and in some cases that also might not be enough... kwin
> disables blur during moving windows for the exact same reason.

Fair enough, disabling blur does fix that issue, so I guess there is nothing to be done about that. Maybe I'll just use a solid background.

> the problem is probably your theme in use...
> the mask that is providing does not take into account antialiasing cases.
> the mask provided should be 1px. narrower from the actual transparent area.
> this is the way plasma dialogs are solving the case.

Then it is an issue with breeze not providing the correct mask, right? Is there a way I can change this, or is this something the breeze devs have to do?
Comment 7 Michail Vourlakos 2022-06-19 15:37:23 UTC
(In reply to Felix Fischer from comment #6)
> Then it is an issue with breeze not providing the correct mask, right? Is
> there a way I can change this, or is this something the breeze devs have to
> do?

nope, you can not do something... its breeze devs/designers that need to provide a fix for this.
Comment 8 doncbugs 2022-07-03 22:20:02 UTC
(In reply to Michail Vourlakos from comment #5)

> if someone wants blur area that is able to move around flowlessly then it
> needs a high end pc and in some cases that also might not be enough... kwin
> disables blur during moving windows for the exact same reason.

I think that's a little unfair Michail. Right now we probably don't have a good solution, but it is technically possible. MacOS has done it for a while now and so have apps like https://store.steampowered.com/app/1787090/MyDockFinder/ 

None of the blurred windows, nor Aurorae themes seem to have the problem of blur lagging behind it. Latte dock appears to have it the worst.
Comment 9 Michail Vourlakos 2022-07-04 06:37:22 UTC
(In reply to doncbugs from comment #8)
> (In reply to Michail Vourlakos from comment #5)
> 
> > if someone wants blur area that is able to move around flowlessly then it
> > needs a high end pc and in some cases that also might not be enough... kwin
> > disables blur during moving windows for the exact same reason.
> 
> I think that's a little unfair Michail. Right now we probably don't have a
> good solution, but it is technically possible. MacOS has done it for a while
> now and so have apps like
> https://store.steampowered.com/app/1787090/MyDockFinder/ 
> 
> None of the blurred windows, nor Aurorae themes seem to have the problem of
> blur lagging behind it. Latte dock appears to have it the worst.

Feel free to provide your fixes then