Bug 455290 - sshmanager import fills in user ID, but editing doesn't allow edits with the user ID filled in (but User ID is read only in this case)
Summary: sshmanager import fills in user ID, but editing doesn't allow edits with the ...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: sshmanager (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-14 22:37 UTC by Al Williams
Modified: 2022-06-18 10:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
attachment-19790-0.html (2.91 KB, text/html)
2022-06-15 06:43 UTC, tcanabrava
Details
attachment-6742-0.html (1.23 KB, text/html)
2022-06-18 09:50 UTC, tcanabrava
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Al Williams 2022-06-14 22:37:14 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Try to change profile for imported host
2. Note that manager reports you should not provide username/key (Message: If use Ssh Config is set, do not specify sshkey or username). Unable to save.
3. Note that the import set the user name and you are unable to change it.
4. Only work around is to directly edit ~/.config/konsolesshconfig while Konsole is NOT running

Portion of .ssh/config:

Host XXX
Hostname XXX.XXX
ForwardX11 yes
ForwardX11Trusted yes
Compression yes
ServerAliveCountMax 3
ServerAliveInterval 15
TCPKeepAlive yes
User MYUSERID

So it appears that the import fills the user ID field (unnecessarily) but the edit feature doesn't allow you to fill it in. But since it is already filled in and you can't change it....

One byproduct of this is that if you try to set a profile to open a session, the sshmanager session overrides the profile setting and since you can't change it....
Comment 1 tcanabrava 2022-06-15 06:43:43 UTC
Created attachment 149726 [details]
attachment-19790-0.html

I’ll look at it

On Tue, 14 Jun 2022 at 23:37 Al Williams <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=455290
>
>             Bug ID: 455290
>            Summary: sshmanager import fills in user ID, but editing
>                     doesn't allow edits with the user ID filled in (but
>                     User ID is read only in this case)
>            Product: konsole
>            Version: unspecified
>           Platform: Neon Packages
>                 OS: Linux
>             Status: REPORTED
>           Severity: normal
>           Priority: NOR
>          Component: sshmanager
>           Assignee: konsole-devel@kde.org
>           Reporter: alw@al-williams.com
>   Target Milestone: ---
>
> SUMMARY
> ***
> NOTE: If you are reporting a crash, please try to attach a backtrace with
> debug
> symbols.
> See
>
> https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
> ***
>
>
> STEPS TO REPRODUCE
> 1. Try to change profile for imported host
> 2. Note that manager reports you should not provide username/key (Message:
> If
> use Ssh Config is set, do not specify sshkey or username). Unable to save.
> 3. Note that the import set the user name and you are unable to change it.
> 4. Only work around is to directly edit ~/.config/konsolesshconfig while
> Konsole is NOT running
>
> Portion of .ssh/config:
>
> Host XXX
> Hostname XXX.XXX
> ForwardX11 yes
> ForwardX11Trusted yes
> Compression yes
> ServerAliveCountMax 3
> ServerAliveInterval 15
> TCPKeepAlive yes
> User MYUSERID
>
> So it appears that the import fills the user ID field (unnecessarily) but
> the
> edit feature doesn't allow you to fill it in. But since it is already
> filled in
> and you can't change it....
>
> One byproduct of this is that if you try to set a profile to open a
> session,
> the sshmanager session overrides the profile setting and since you can't
> change
> it....
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 2 Bug Janitor Service 2022-06-17 21:51:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/687
Comment 3 Al Williams 2022-06-17 21:53:30 UTC
(In reply to Bug Janitor Service from comment #2)
> A possibly relevant merge request was started @
> https://invent.kde.org/utilities/konsole/-/merge_requests/687

I went ahead and fixed it and passed along the above-mentioned merge request.
Comment 4 tcanabrava 2022-06-18 09:50:01 UTC
Created attachment 149882 [details]
attachment-6742-0.html

You are my favorite kind of bug reporter.
Merging


On Fri, 17 Jun 2022 at 22:53 Al Williams <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=455290
>
> --- Comment #3 from Al Williams <alw@al-williams.com> ---
> (In reply to Bug Janitor Service from comment #2)
> > A possibly relevant merge request was started @
> > https://invent.kde.org/utilities/konsole/-/merge_requests/687
>
> I went ahead and fixed it and passed along the above-mentioned merge
> request.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 5 tcanabrava 2022-06-18 10:12:43 UTC
Git commit 4276bd33e2f4239dfcd4b4551104b4ac83daa73a by Tomaz  Canabrava, on behalf of Al Williams.
Committed on 18/06/2022 at 10:10.
Pushed by tcanabrava into branch 'master'.

Fix error when trying to edit the editable parts of an imported ssh host with a user name/key.

M  +5    -2    src/plugins/SSHManager/sshmanagerpluginwidget.cpp

https://invent.kde.org/utilities/konsole/commit/4276bd33e2f4239dfcd4b4551104b4ac83daa73a