Bug 455186 - Save icon do not change state
Summary: Save icon do not change state
Status: RESOLVED DUPLICATE of bug 95849
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 22.04.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-12 16:39 UTC by witchhunter
Modified: 2023-07-01 22:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
inconsistency (16.65 KB, image/png)
2022-06-12 16:39 UTC, witchhunter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description witchhunter 2022-06-12 16:39:19 UTC
Created attachment 149644 [details]
inconsistency

SUMMARY
***
This is more a distraction, then a bug.
Save icon on toolbar do not change its state. It is always enabled. 
'Undo' and 'redo' icons behave as should, though.
***


STEPS TO REPRODUCE
1. Open file in Kate
2. Type one character
3. Undo

OBSERVED RESULT
Save icon has enabled state, although there are no changes.

EXPECTED RESULT
Save icon should be disabled.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Testing Edition VM
KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4


ADDITIONAL INFORMATION
Comment 1 Christoph Cullmann 2022-06-12 17:04:05 UTC
Hi, this is by intention.
One should always be able to save the file.
Other editors handle that similarly.
Comment 2 witchhunter 2022-06-12 21:04:26 UTC
(In reply to Christoph Cullmann from comment #1)

Hi, OK so you've intrigued me and I did a quick search, for the record (some of these have only menu, though):
GNOME text editor, Xed - do not change icon state
Mousepad, Geany, Qt Creator, FeatherPad - do change icon state
LibreOffice -  do not change icon state, but change icon itself adding little red dot at corner

Perhaps the latter is the optimal solution. Never used M$ products, though.
Anyway, as I sad, it is more a distraction than anything else.
Comment 3 Waqar Ahmed 2022-08-16 13:35:51 UTC

*** This bug has been marked as a duplicate of bug 95849 ***
Comment 4 Karl 2023-07-01 22:28:00 UTC
This Is a pretty much a bug - 
We have ended up with a rather cluttered an non intuitive UI.
The problem is the state of save and the save button are in two different places.

I see that the loaded state is indicated in the document tree by a save icon by the file name - but clicking on it does not save.

So there are now 3 places where one sees the save icon - on the tool bar  - just under the tool bar (document bar) and in the document tree.   If you are going to put the icon next to the file name - it should work to save as well. 

The other save buttons are not intuitive as to WHICH file they are saving ( some might thing them a save-all)..