Bug 455149 - Unable to continue conversation. After first message sent, "Send Arrow" remains inactive.
Summary: Unable to continue conversation. After first message sent, "Send Arrow" remai...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: messaging-application (show other bugs)
Version: unspecified
Platform: Slackware Linux
: NOR normal
Target Milestone: ---
Assignee: Dmytrii
URL:
Keywords: junior-jobs
: 463248 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-06-11 02:59 UTC by alumpezdek
Modified: 2023-04-21 16:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alumpezdek 2022-06-11 02:59:17 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

STEPS TO REPRODUCE
1. Send message to recipient
2. After first message sent to recipient, input area blank, send arrow inactive
3. Wait for response from Recipient

OBSERVED RESULT
1. Type new message to same user.  send arrow remains inactive. Message not sent.

EXPECTED RESULT
1. Ability to respond to recipient message

WORK AROUND
1. Select different recipient
2. Select original recipient
3. Retype message.
4. Send arrow becomes active. 
5. Message sent.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Slackware 15.0 kernel 5.13.19
(available in About System)
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Comment 1 Simon Redman 2022-12-27 03:52:32 UTC
*** Bug 463248 has been marked as a duplicate of this bug. ***
Comment 2 Simon Redman 2022-12-27 03:59:01 UTC
Marking as confirmed since another user reported a duplicate bug and I can reproduce the same behavior.

Note that pressing the enter button to send causes the button to be disabled, but you can send multiple messages in the same conversation by using enter to send. If I were guessing, something is wrong with the `disabled` state of the send button, probably in the part of the code where it tries to prevent sending duplicate messages by briefly disabling the button.

Marking this as a junior job. It's probably a simple fix, someone just needs to poke into the QML and find where the disabled state of the button is set, and find where it should be re-enabled.
Comment 3 Dmytrii 2023-01-17 23:19:08 UTC
(In reply to Simon Redman from comment #2)
> Marking as confirmed since another user reported a duplicate bug and I can
> reproduce the same behavior.
> 
> Note that pressing the enter button to send causes the button to be
> disabled, but you can send multiple messages in the same conversation by
> using enter to send. If I were guessing, something is wrong with the
> `disabled` state of the send button, probably in the part of the code where
> it tries to prevent sending duplicate messages by briefly disabling the
> button.
> 
> Marking this as a junior job. It's probably a simple fix, someone just needs
> to poke into the QML and find where the disabled state of the button is set,
> and find where it should be re-enabled.

Hello, I found some QML positioning errors. It is not just enabled/disabled issue. This property depends on messageField textarea which became undefined. I can fix it. Could you assign this bug to me, or should I do it on my own?
Comment 4 Simon Redman 2023-01-17 23:32:12 UTC
(In reply to Dmytrii from comment #3)
> 
> Hello, I found some QML positioning errors. It is not just enabled/disabled
> issue. This property depends on messageField textarea which became
> undefined. I can fix it. Could you assign this bug to me, or should I do it
> on my own?

Feel free to take ownership yourself. Thanks for stepping up! Please reach out to the team if you get stuck or want to ask questions: https://community.kde.org/KDEConnect#Development
Comment 5 Dmytrii 2023-01-18 23:17:47 UTC
Created merge request for this https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/518
Comment 6 Simon Redman 2023-04-21 16:29:09 UTC
Git commit 0d02a6f99e46e002a89c259ae30b02f23661e06c by Simon Redman, on behalf of Dmytrii Zavalnyi.
Committed on 21/04/2023 at 16:28.
Pushed by sredman into branch 'master'.

Fix inactive "Send Arrow" in smsapp after first message sent

The "enabled" property of the button was set to false and has overwritten the default value based on the message length.
The message field had "anchors.fill" positioning and raised  "Binding loop detected for property "implicitHeight"" error.
attachmentList property of ChatMessage didn't have the default value and was undefined.

M  +1    -1    smsapp/qml/ChatMessage.qml
M  +13   -10   smsapp/qml/SendingArea.qml

https://invent.kde.org/network/kdeconnect-kde/commit/0d02a6f99e46e002a89c259ae30b02f23661e06c