Bug 455140 - Proxy clips are re-generated when using LRV files
Summary: Proxy clips are re-generated when using LRV files
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: 22.04.1
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-10 19:37 UTC by Ricardo
Modified: 2022-06-17 20:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo 2022-06-10 19:37:45 UTC
Hi all, I configured my kdenlive to use LRV files as proxy clips. I add the LRV files to the project bin and then I add a clip to the timeline.

Kdenlive recognize the LRV as proxy clips on the project bin and the time line. All good till here.

If I click over a clip on the project bin and I uncheck the proxy option, kdenlive uses the clip full version but, If I mark the proxy option again, kdenlive start to encode a new proxy clip instead of use the LRV.

Why is this hepening? seems like a bug for me. I think the pseudocode for this should be something like:

1.- Proxy clip option marked
2.- Check if there are a LRV file in the path specified on the settings
3.- If the LRV file exists, use it, otherwise, create a new proxy clip. 

STEPS TO REPRODUCE
1.  Configure kdenlive to use LRV as proxy clips
2. Load and LRV on the project bin
3. Right click on the clip on project bin
4. Unmark the proxy clip option.
5. Right click over the clip again
6. Mark the proxy clip option

OBSERVED RESULT
Kdenlive star to enconde a new proxy clip

EXPECTED RESULT
kdenlive should user the LRV file as configured

SOFTWARE/OS VERSIONS
Distro: Debian bullseye
Kdenlive: 22.04.1
Package: appimage
Comment 1 Jean-Baptiste Mardelle 2022-06-11 14:03:01 UTC
Git commit 9564b4093d0ddef1cf905a60db617d46d1175231 by Jean-Baptiste Mardelle.
Committed on 11/06/2022 at 14:00.
Pushed by mardelle into branch 'master'.

Fixes for external proxies.

M  +36   -27   src/bin/projectclip.cpp

https://invent.kde.org/multimedia/kdenlive/commit/9564b4093d0ddef1cf905a60db617d46d1175231
Comment 2 Jean-Baptiste Mardelle 2022-06-11 20:55:06 UTC
Thanks for your report. I could not exactly reproduce your problem, but pushed some fixes when adding an external proxy clip to the project. Could you test the latest daily development AppImage and tell me if the bug is fixed ?
You can get it here:
https://binary-factory.kde.org/job/Kdenlive_Nightly_appimage-centos7/lastSuccessfulBuild/artifact/kdenlive-master-246-linux-64-gcc.AppImage
Comment 3 Ricardo 2022-06-12 10:30:52 UTC
Hi, the behavior seems to be the same but with some other problems. This what I've done:

Kdenlive version: Version 22.07.70 (rev. 8d9869d25)

Create new project with these settings on proxy tab:
Enable proxy clips -> checked
Use external proxy clips -> GoPro LRV

Save it (empty)

Add an LRV clip to the project bin. Kdenlive do some "magic" and shows the MP4 clip on the project bin with the "P" indicating it is a proxy clip.
On "Clip Properties" tab, the "Proxy clip" is marked and the path points to the LRV. (This is good)

Add the clip on the project bin to the time line. The time line shows the "P" on the thumbnail. (This is good)

On "Project Bin" tab, right click on the clip and uncheck the "Proxy Clip" option on the contextual menu. Kdenlive do "something".

The "P" is gone on the time line, kde is using the full clip as I see it on the project monitor. (This is good)

The "P" still shown on the project bin clip and on the "Clip Properties" tab, the "Proxy clip" option is *checked* and is pointing to the original clip. (This is bad)

Right click on the "Project bin" clip, mark the "Proxy Clip" on the contextual menu. I go to the "Clip Properties" tab and the "Proxy clip" option stills marked is marked but the path is pointing to the original clip. (This is bad)

The time line doesn't shows the "P" as it should be. (This is bad)

On the Project Monitor I'm still viewing the original clip. (This is bad)

And that is, the problem hamdling external proxy clips still there.

Thank you for your effort,
Comment 4 Jean-Baptiste Mardelle 2022-06-12 16:32:29 UTC
I don't have LRV files and tested with SONY PXW proxies and everthing seems to work for me.
Can you confirm that your LRV proxy clip is located in the same folder as the original and that the clips are named according to our setting:

original clip:
GX1234.MP4
Proxy clip:
GL1234.LRV

(Where 1234 is the name of the clip, prefix and extension in capital letters...)
Comment 5 Ricardo 2022-06-13 18:41:06 UTC
Hello, I confirm the LRV files are in the same directory of MP4 files.

The clips name aren't the one you are telling me. This is a ls output of one of my directories. You can confirm the LRV files are on the same directory than MP4 files and checl the file naming scheme.

total 58730704
-rwxr-xr-x 1 ricardo ricardo   10009230 May 21 11:17 GOPR0028.LRV
-rwxr-xr-x 1 ricardo ricardo  168542803 May 22 17:19 GOPR0028.MP4
-rwxr-xr-x 1 ricardo ricardo  237583894 May 21 11:32 GOPR0029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004870057 May 22 17:20 GOPR0029.MP4
-rwxr-xr-x 1 ricardo ricardo  237615912 May 21 11:43 GP010029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004960783 May 22 17:22 GP010029.MP4
-rwxr-xr-x 1 ricardo ricardo  237591018 May 21 11:55 GP020029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004976458 May 22 17:23 GP020029.MP4
-rwxr-xr-x 1 ricardo ricardo  237506016 May 21 12:07 GP030029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004861887 May 22 17:25 GP030029.MP4
-rwxr-xr-x 1 ricardo ricardo  237596277 May 21 12:19 GP040029.LRV
-rwxr-xr-x 1 ricardo ricardo 4005081854 May 22 17:26 GP040029.MP4
-rwxr-xr-x 1 ricardo ricardo  237599276 May 21 12:31 GP050029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004885491 May 22 17:28 GP050029.MP4
-rwxr-xr-x 1 ricardo ricardo  237594644 May 21 12:43 GP060029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004900331 May 22 17:29 GP060029.MP4
-rwxr-xr-x 1 ricardo ricardo  237501505 May 21 12:54 GP070029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004990906 May 22 17:31 GP070029.MP4
-rwxr-xr-x 1 ricardo ricardo  237596485 May 21 13:06 GP080029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004855132 May 22 17:32 GP080029.MP4
-rwxr-xr-x 1 ricardo ricardo  237605350 May 21 13:18 GP090029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004985341 May 22 17:34 GP090029.MP4
-rwxr-xr-x 1 ricardo ricardo  237593523 May 21 13:30 GP100029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004900081 May 22 17:35 GP100029.MP4
-rwxr-xr-x 1 ricardo ricardo  237507590 May 21 13:42 GP110029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004915143 May 22 17:37 GP110029.MP4
-rwxr-xr-x 1 ricardo ricardo  237597195 May 21 13:54 GP120029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004925868 May 22 17:38 GP120029.MP4
-rwxr-xr-x 1 ricardo ricardo  237598017 May 21 14:05 GP130029.LRV
-rwxr-xr-x 1 ricardo ricardo 4004958921 May 22 17:40 GP130029.MP4
-rwxr-xr-x 1 ricardo ricardo   31694597 May 21 14:07 GP140029.LRV
-rwxr-xr-x 1 ricardo ricardo  534719409 May 22 17:40 GP140029.MP4

The files names are the same, the only difference is the extension. I'm using a GoPro Hero 5.
Comment 6 Jean-Baptiste Mardelle 2022-06-14 11:30:52 UTC
Git commit ba5e921916992cccd1d868f1e696a077d9f3f179 by Jean-Baptiste Mardelle.
Committed on 14/06/2022 at 11:30.
Pushed by mardelle into branch 'master'.

Fix incorrect behavior of external proxies, allow multiple patterns by profile

M  +3    -1    data/externalproxies.rc
M  +82   -25   src/bin/projectclip.cpp
M  +9    -0    src/bin/projectclip.h
M  +1    -19   src/doc/kdenlivedoc.cpp
M  +26   -7    src/project/dialogs/projectsettings.cpp

https://invent.kde.org/multimedia/kdenlive/commit/ba5e921916992cccd1d868f1e696a077d9f3f179
Comment 7 Jean-Baptiste Mardelle 2022-06-14 11:33:29 UTC
Thanks for your feedback. Your naming scheme was different from what we expected. I now fixed it with several other issues I found in the proxy handling. Please test the next daily build for today that should be ready in about 8 hours:
https://binary-factory.kde.org/job/Kdenlive_Nightly_appimage-centos7/
Comment 8 Ricardo 2022-06-15 21:05:21 UTC
Hello, I made some tests. The program loads the proxy as expected and then it handle them ok, the only thing I see is the clip has no sound when I drag it to the timeline. On the clip monitor I have sound but on the project monitor I don't have it and when I drag the clip to the time line, there is no audio track.

The Kdenlive vernsion I'm using is Version 22.07.70 (rev. 99bea51a2)
Comment 9 Jean-Baptiste Mardelle 2022-06-15 21:22:39 UTC
Ok, thanks for the feedback. Would it be possible for you to upload a short sample of an original clip with its LRV proxy here or somewhere else so that I can further debug the problem ?
Comment 10 Ricardo 2022-06-15 22:35:38 UTC
Hello, I could give you the whole clip and its lrv (3.8 GB and 227 MB) if you want. Give me an ftp or something like that to do the upload.
Comment 11 Jean-Baptiste Mardelle 2022-06-16 06:30:16 UTC
Git commit 76e4b8398574280acc2ec58b04e4ce3d14d264a1 by Jean-Baptiste Mardelle.
Committed on 16/06/2022 at 06:30.
Pushed by mardelle into branch 'master'.

Fix recent regression breaking audio.
Related to #1461

M  +5    -10   src/mltcontroller/clipcontroller.cpp

https://invent.kde.org/multimedia/kdenlive/commit/76e4b8398574280acc2ec58b04e4ce3d14d264a1
Comment 12 Jean-Baptiste Mardelle 2022-06-16 07:17:39 UTC
Oh, turns out the audio issue was probably due to an unrelated regression that I just fixed. Please test again with today's build, thanks.
Comment 13 Ricardo 2022-06-17 18:44:39 UTC
Ok!!!! working like a charm!!! thank you so much. When this fix will be available on the stable release?
Comment 14 Jean-Baptiste Mardelle 2022-06-17 20:41:13 UTC
Git commit e5911772c142d0d0bc45c944ab743d93bb84f9e0 by Jean-Baptiste Mardelle.
Committed on 17/06/2022 at 20:23.
Pushed by mardelle into branch 'release/22.04'.

Fixes for external proxies.

M  +36   -1    src/bin/projectclip.cpp

https://invent.kde.org/multimedia/kdenlive/commit/e5911772c142d0d0bc45c944ab743d93bb84f9e0
Comment 15 Jean-Baptiste Mardelle 2022-06-17 20:41:21 UTC
Git commit 3e871332c6cc6c3c849211f837c297fd90c3c39a by Jean-Baptiste Mardelle.
Committed on 17/06/2022 at 20:26.
Pushed by mardelle into branch 'release/22.04'.

Fix incorrect behavior of external proxies, allow multiple patterns by profile

M  +3    -1    data/externalproxies.rc
M  +83   -26   src/bin/projectclip.cpp
M  +9    -0    src/bin/projectclip.h
M  +1    -19   src/doc/kdenlivedoc.cpp
M  +26   -7    src/project/dialogs/projectsettings.cpp

https://invent.kde.org/multimedia/kdenlive/commit/3e871332c6cc6c3c849211f837c297fd90c3c39a
Comment 16 Jean-Baptiste Mardelle 2022-06-17 20:43:40 UTC
I have backported the fix to 22.04 branch so the fix will be released as Kdenlive 22.04.3 around the 10th of July.