Created attachment 149600 [details] screenshot1 STEPS TO REPRODUCE 1. open Global Theme KCM or Login Screen (SDDM) KCM 2. click on the button to get a new global theme or SDDM theme 3. click on the button to install any theme 4. when your password is requested, cancel the password dialog OBSERVED RESULT error messages seen in the attached screenshots EXPECTED RESULT no error message SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.25.80 KDE Frameworks Version: 5.95.0 Qt Version: 5.15.4 Graphics Platform: Wayland
Created attachment 149601 [details] screenshot2
>screenshot1 The question is, what the expected behavior should be. The global themes install multiple assets and in your scenario we only "fail" in the installation of one. Though explicitly skipping the installation of an asset that needs to be installed with root privileges seems like a valid usecase. @Nate @Leinir What do you think? >screenshot2 Seems reasonable. For the KRunner plugin installer, I have already added API in KNewStuff, which means we can simply reuse that.
Yes, I guess we need to be clearer about differentiating between "the action failed" and "the action mostly succeeded, but this part of it failed". Right now after the second one happens, the state is not clear. Maybe we need to introduce a "partially installed" state in the UI that gives the user the opportunity to see what's not installed and try again to install those things. Being able to skip the installation of something that requires root privileges also seems reasonable, as not all users will have that.
In KAuth we can not tell if an action was cancelled. I looked into it and several other devs confirmed it :/
> Maybe we need to introduce a "partially installed" state in the UI that gives the user the opportunity to see what's not installed and try again to install those things. Thought that would mean adding new API in KNewStuff for an additional status or we save it in a separate data file. IMHO both feels kinda hacky. Or we could say that the global theme is considered installed, but after parts of the installation failed, we show a warning.
Unless anyone has better ideas, this should be closed as WONTFIX