Bug 455129 - Current wallpaper is no longer highlighted after adding an image
Summary: Current wallpaper is no longer highlighted after adding an image
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (other bugs)
Version First Reported In: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-06-10 13:42 UTC by Patrick Silva
Modified: 2022-09-25 11:01 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26
Sentry Crash Report:


Attachments
screen recording (1.93 MB, video/webm)
2022-09-25 10:49 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2022-06-10 13:42:54 UTC
STEPS TO REPRODUCE
1. right-click on desktop and choose 'Configure desktop and wallpaper...'
2. click on '+ Add image...' button and open an image file
3. 

OBSERVED RESULT
current wallpaper is no longer highlighted. If I close desktop settings window by clicking on 'OK' button and then reopen it, the bug persists.

EXPECTED RESULT
current wallpaper is still highlighted after the provided steps

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.25.80
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4
Graphics Platform: Wayland
Comment 1 Fushan Wen 2022-06-10 13:44:50 UTC
Can't reproduce on X11. Is it only reproducible on Wayland?
Comment 2 Patrick Silva 2022-06-10 14:23:55 UTC
I was able to reproduce exactly the observed result mentioned in comment 0 once on X11. Now the result is a bit different on both Wayland and X11: the current wallpaper is not hightlighted immediately after opening an image (the next wallpaper in the grid is highlighted instead), but it is when I reopen the desktop settings.
Comment 3 Fushan Wen 2022-06-10 14:54:18 UTC
Git commit c857d3bad57b9e8a1606fe9035a01afb91a9033c by Fushan Wen.
Committed on 10/06/2022 at 14:53.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: set position in `resetCurrentIndex`

Move the position of the image list view to the currently selected
item's index.

M  +1    -0    wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c857d3bad57b9e8a1606fe9035a01afb91a9033c
Comment 4 Fushan Wen 2022-06-10 14:54:27 UTC
Git commit 1ae570e4b3c6dd6a5e775d24d7ebaed9d31c46a3 by Fushan Wen.
Committed on 10/06/2022 at 14:53.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: scroll to top after finishing adding images using file dialog

M  +5    -0    wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml
M  +1    -0    wallpapers/image/plugin/imagebackend.cpp
M  +5    -0    wallpapers/image/plugin/imagebackend.h

https://invent.kde.org/plasma/plasma-workspace/commit/1ae570e4b3c6dd6a5e775d24d7ebaed9d31c46a3
Comment 5 Fushan Wen 2022-06-10 14:54:35 UTC
Git commit bf97a204b8e61ac0770551b5194c044e63bcf8f8 by Fushan Wen.
Committed on 10/06/2022 at 14:53.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: scroll to top to view added images after DnD operations

M  +2    -0    wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml
M  +5    -0    wallpapers/image/imagepackage/contents/ui/config.qml

https://invent.kde.org/plasma/plasma-workspace/commit/bf97a204b8e61ac0770551b5194c044e63bcf8f8
Comment 6 Fushan Wen 2022-06-10 15:00:23 UTC
Can't reproduce on Wayland either even before those commits. Need more people to confirm the bug.
Comment 7 Nate Graham 2022-06-10 15:31:25 UTC
Also can't confirm the issue.
Comment 8 Fushan Wen 2022-06-10 16:14:53 UTC
Please reopen this bug if you still see the same phenomenon after updating the system to the latest version.
Comment 9 Patrick Silva 2022-09-24 22:50:32 UTC
Can reproduce on neon unstable and Arch Linux.

Operating System: Arch Linux
KDE Plasma Version: 5.25.90
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Graphics Platform: Wayland
Comment 10 Fushan Wen 2022-09-25 02:09:41 UTC
Still can't reproduce. Do you have a screen record?
Comment 11 Patrick Silva 2022-09-25 10:49:34 UTC
Created attachment 152410 [details]
screen recording

Here is a video recorded on neon unstable.
Comment 12 Fushan Wen 2022-09-25 11:01:04 UTC
Git commit fe9604caa955d4417801f8b2b4dabf1ad4350397 by Fushan Wen.
Committed on 25/09/2022 at 10:59.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: reset grid index after new images are added

Otherwise the index will still be the old index.
FIXED-IN: 5.26

M  +1    -0    wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml

https://invent.kde.org/plasma/plasma-workspace/commit/fe9604caa955d4417801f8b2b4dabf1ad4350397
Comment 13 Fushan Wen 2022-09-25 11:01:23 UTC
Git commit 89dce8a127a65844cd7a0ae71d185aba403fc4f6 by Fushan Wen.
Committed on 25/09/2022 at 11:00.
Pushed by fusionfuture into branch 'Plasma/5.26'.

wallpapers/image: reset grid index after new images are added

Otherwise the index will still be the old index.
FIXED-IN: 5.26
(cherry picked from commit fe9604caa955d4417801f8b2b4dabf1ad4350397)

M  +1    -0    wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml

https://invent.kde.org/plasma/plasma-workspace/commit/89dce8a127a65844cd7a0ae71d185aba403fc4f6