Bug 454908 - Accent color from wallpaper no longer automatically changes when slideshow wallpaper image changes
Summary: Accent color from wallpaper no longer automatically changes when slideshow wa...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-06-05 21:47 UTC by Nate Graham
Modified: 2022-06-06 01:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-06-05 21:47:41 UTC
Now, when the slideshow wallpaper changes, the accent color only changes when plasmashell is restarted.

I did a git bisect and found that it's one of the commits in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1638, but couldn't pinpoint the exact one because those commits are quite inter-related and at plasma-workspace doesn't build when some of them are HEAD.
Comment 1 Bug Janitor Service 2022-06-06 00:43:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1808
Comment 2 Bug Janitor Service 2022-06-06 00:55:19 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/972
Comment 3 Fushan Wen 2022-06-06 01:09:50 UTC
Git commit d2e4745813d33c8471f42383b45842d987a488e1 by Fushan Wen.
Committed on 06/06/2022 at 00:51.
Pushed by fusionfuture into branch 'master'.

desktoppackage: only depend on `repaintNeeded` signal to update wallpaper colors

This avoids extracting colors from wallpapers during transitions.

M  +1    -11   desktoppackage/contents/views/Desktop.qml

https://invent.kde.org/plasma/plasma-desktop/commit/d2e4745813d33c8471f42383b45842d987a488e1
Comment 4 Nate Graham 2022-06-06 01:11:58 UTC
Git commit b8c7ba8a22033e07c7020e0e296f570a587ecd42 by Nate Graham, on behalf of Fushan Wen.
Committed on 06/06/2022 at 01:05.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: update accent color when image finishes loading
FIXED-IN: 5.26

M  +4    -0    wallpapers/image/imagepackage/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b8c7ba8a22033e07c7020e0e296f570a587ecd42