Bug 454841 - Not hard code the order of the day, month and year
Summary: Not hard code the order of the day, month and year
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: plugins: git (show other bugs)
Version: 22.04.1
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Sebastian Dörner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-04 15:25 UTC by Eastern Li
Modified: 2024-03-30 12:54 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/sdk/dolphin-plugins/-/commit/ee7cbc1f75df67653c017cb697e28be74064f0dc
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eastern Li 2022-06-04 15:25:40 UTC 
When show log, an arg "--date=format:%d-%m-%Y" is hard coded. In different regions, people are used to different orders of the day, month and year. Perhaps we could mark the string as i18n so that it can be localised?

The arg string is in https://invent.kde.org/sdk/dolphin-plugins/-/blob/c01c0ffb8fbd92df2b48c34769a584dbc12d0ea9/git/fileviewgitplugin.cpp#L469
Comment 1 Bug Janitor Service 2024-03-28 12:20:12 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/55
Comment 2 Méven Car 2024-03-30 12:54:17 UTC 
Git commit ee7cbc1f75df67653c017cb697e28be74064f0dc by Méven Car, on behalf of Alexander Johansen.
Committed on 30/03/2024 at 12:54.
Pushed by meven into branch 'master'.

Use locales date in Git log

This tells Git to use the system locale for its date instead of hard-coding a format.

M  +1    -1    git/fileviewgitplugin.cpp

https://invent.kde.org/sdk/dolphin-plugins/-/commit/ee7cbc1f75df67653c017cb697e28be74064f0dc