Bug 454788 - Maximize vertically does not take into account increased titlebar size with touch mode
Summary: Maximize vertically does not take into account increased titlebar size with t...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: rules (show other bugs)
Version: 5.24.90
Platform: Manjaro Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-03 09:34 UTC by Jesse Laatu
Modified: 2024-06-09 14:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Laatu 2022-06-03 09:34:01 UTC
SUMMARY
When using the Maximize vertically rule and touch mode(Workspace behavior > General Behavior > Touch Mode) together the window is maximized to a wrong size. Normal maximize works as intended.


STEPS TO REPRODUCE
1. Workspace behavior > General Behavior > Touch Mode: Always enabled
2. Window rule to maximize vertically
3. trigger the rule

OBSERVED RESULT
Window is maximized too big vertically and overflows the screen(panel: Windows can cover) or panel(depending on panel settings)

EXPECTED RESULT
Window is vertically maximized as it would be when using normal maximize.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro-arm / kde-unstable
KDE Plasma Version: 5.25.80
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4

ADDITIONAL INFORMATION
Raspberry pi 400, 800x480 touch screen, 100% scaling on wayland.
Comment 1 Ismael Asensio 2022-06-03 09:59:22 UTC
Doies the same thing happen when maximizing vertically with the button  (not through a rule)?

Also, is this on X11 or Wayland (in Wayland this would make some.semse as there's no native concept of partial maximizing there)?

Thanks!
Comment 2 Jesse Laatu 2022-06-03 10:17:50 UTC
(In reply to Ismael Asensio from comment #1)
> Doies the same thing happen when maximizing vertically with the button  (not
> through a rule)?
> 
> Also, is this on X11 or Wayland (in Wayland this would make some.semse as
> there's no native concept of partial maximizing there)?
> 
> Thanks!

I did mention wayland in the additional information, sorry if it wasn't clear. I have some issues with x11 on the setup so I have not tested that.
I tested vertical maximization with a hotkey and it seems to work as expected. I was using the rules to maximize windows in both directions to have them completely maximized as there is no maximize rule. It is a tiny 4" touchscreen, so increasing the size of some elements like the touch mode does is pretty useful, I'm not sure how the 800x480 resolution affects this, but likely it is more notieceable.
Comment 3 Zamundaaa 2024-06-09 14:49:13 UTC
Can't reproduce in Plasma 6