Bug 454526 - Alternatives popup can be opened multiple times, and they overlap one another
Summary: Alternatives popup can be opened multiple times, and they overlap one another
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.24.90
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-28 10:13 UTC by John
Modified: 2024-01-22 16:14 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John 2022-05-28 10:13:21 UTC
SUMMARY
The alternatives menu doesn't close if you click somewhere else

STEPS TO REPRODUCE
1. Right-click on the start menu or on the hour / date or on the panel
2.  Click on the "Show Alternatives" item
3. Don't click on anything there
4. Click on the desktop

OBSERVED RESULT
In case you change your mind and don't want to switch to an alternative or you want to do it later and not just open something from the desktop, that menu remains open as if it was set to keep open like other windows have.

EXPECTED RESULT
The menu should close itself as you have changed your mind and you want to do do something else or a call call came in and you had to click the answer button or you had to stop the music, etc. 
I don't think this is such an important change that it cannot close until the users chooses something.
BTW, if you have Firefox open for example, then click on the "Show Alternatives" for the start menu or hour /date and then click on Firefox, it will look like it worked because Firefox comes in front.
I noticed only after I minimized Firefox and saw that the alternatives menu is still open, even though I thought id disappeared, which made me open it again multiple times so in the end I had to click on its "Cancel" button 2-3 times
this is how I discovered that you can actually open it multiple time and I don't know what could be useful in that.
Maybe if you have installed an alternative in the meantime, but probably the one that it's already open should be refreshed to show also the newly installed alternative instead of open it again in front of the other one

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.95
Qt Version: 5.15.4

ADDITIONAL INFORMATION
From: neon-testing-20220524-1822.iso + updates from Discover
Tested on Wayland

Not sure if this is really a bug or it works as intended, but to seemed more of a bug or at least a bit strange.
BTW I didn't know in which product should I report this, please move it the the right place if you can or let me know to recreate it somewhere else.
Comment 1 Felipe Kinoshita 2022-05-28 13:35:19 UTC
Can confirm!
Comment 2 Nate Graham 2022-06-01 17:27:58 UTC
That's why there's a Cancel button; you click that to close it. I don't really see what the problem is with that, IMO.

Being to open it multiple times is definitely a bug though. Let's use this bug report to track that issue.
Comment 3 Nate Graham 2023-09-18 17:21:17 UTC
This is fixed in Plasma 6.
Comment 4 Fushan Wen 2023-10-28 08:17:58 UTC
Not fixed in yesterday's build
Comment 5 Nate Graham 2023-10-30 17:33:19 UTC
Can confirm, maybe a recent regression.
Comment 6 Niccolò Venerandi 2024-01-12 12:22:58 UTC
This is pretty much impossible to notice now because of https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1555#note_848874, whereas it was much more of a problem before it. However I'm not sure that MR was a good idea. I'll still try to fix the issue for both scenarios
Comment 7 Niccolò Venerandi 2024-01-17 22:16:26 UTC
Actually, huh, it's not "pretty much impossible to notice", it's not happening at all. How are y'all reproducing this bug? I can't see it.
Comment 8 Nate Graham 2024-01-17 23:57:35 UTC
Looking more closely, it's not that multiple ones are opened on top of one another, but rather than you can open a second one that replaces the first when the first is already open. So maybe all we need to do is disable the menu item to open it when it's already open.
Comment 9 Bug Janitor Service 2024-01-19 13:31:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3788
Comment 10 Nate Graham 2024-01-22 15:47:27 UTC
Git commit 51caf6045db1f8ae1362d7b750a1fff992e4f540 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 22/01/2024 at 16:47.
Pushed by ngraham into branch 'master'.

Only allow showing one Alternatives dialog at a time
FIXED-IN: 6.0

M  +7    -2    shell/shellcorona.cpp
M  +1    -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/51caf6045db1f8ae1362d7b750a1fff992e4f540
Comment 11 Nate Graham 2024-01-22 16:14:53 UTC
Git commit 5c85167a1ab1635ed8a092886369df361ec40def by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 22/01/2024 at 16:50.
Pushed by ngraham into branch 'Plasma/6.0'.

Only allow showing one Alternatives dialog at a time
FIXED-IN: 6.0


(cherry picked from commit 51caf6045db1f8ae1362d7b750a1fff992e4f540)

M  +7    -2    shell/shellcorona.cpp
M  +1    -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/5c85167a1ab1635ed8a092886369df361ec40def