Bug 454517 - Pager applet does not resize correctly after a screen is enabled
Summary: Pager applet does not resize correctly after a screen is enabled
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Pager widget (show other bugs)
Version: 5.24.90
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-05-28 06:28 UTC by Fushan Wen
Modified: 2022-06-04 17:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25
Sentry Crash Report:


Attachments
Before.png (8.04 KB, image/png)
2022-05-28 06:28 UTC, Fushan Wen
Details
After.png (7.12 KB, image/png)
2022-05-28 06:28 UTC, Fushan Wen
Details
Panel (109.23 KB, image/png)
2022-06-04 15:54 UTC, Victor Ryzhykh
Details
Rever view (149.96 KB, image/png)
2022-06-04 16:28 UTC, Victor Ryzhykh
Details
layout.js file (4.51 KB, application/x-javascript)
2022-06-04 17:04 UTC, Victor Ryzhykh
Details
test_fix1.tar.gz (8.25 KB, application/gzip)
2022-06-04 17:08 UTC, Fushan Wen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2022-05-28 06:28:06 UTC
Created attachment 149279 [details]
Before.png

SUMMARY
If I enable a screen in kscreen kcm, the pager applet does not resize correctly. It overlaps the task manager instead.


STEPS TO REPRODUCE
1. Enable a previously disabled screen in kscreen kcm

OBSERVED RESULT
See Before.png

EXPECTED RESULT
See After.png

SOFTWARE/OS VERSIONS
Regression found in panel refactoring
Comment 1 Fushan Wen 2022-05-28 06:28:24 UTC
Created attachment 149280 [details]
After.png
Comment 3 Nate Graham 2022-06-03 15:53:24 UTC
Git commit d03aa17cd36bdeb8c5d22d04e8137edcf5bcbc82 by Nate Graham, on behalf of Fushan Wen.
Committed on 03/06/2022 at 15:53.
Pushed by ngraham into branch 'master'.

containments/panel: fix Layout binding in `appletContainerComponent`

`lastSpacer` is still required because depending on
implicitWidth/implicitHeight is not reliable as they are usually updated
too late in a layout.
Related: bug 454095
FIXED-IN: 5.25

M  +5    -2    containments/panel/contents/ui/ConfigOverlay.qml
M  +24   -19   containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/d03aa17cd36bdeb8c5d22d04e8137edcf5bcbc82
Comment 4 Nate Graham 2022-06-03 15:54:32 UTC
Git commit c5e6eff14f0f18afbcf51ae372bca68afe22de52 by Nate Graham, on behalf of Fushan Wen.
Committed on 03/06/2022 at 15:54.
Pushed by ngraham into branch 'Plasma/5.25'.

containments/panel: fix Layout binding in `appletContainerComponent`

`lastSpacer` is still required because depending on
implicitWidth/implicitHeight is not reliable as they are usually updated
too late in a layout.
Related: bug 454095
FIXED-IN: 5.25


(cherry picked from commit d03aa17cd36bdeb8c5d22d04e8137edcf5bcbc82)

M  +5    -2    containments/panel/contents/ui/ConfigOverlay.qml
M  +24   -19   containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/c5e6eff14f0f18afbcf51ae372bca68afe22de52
Comment 5 Victor Ryzhykh 2022-06-04 15:54:42 UTC
Created attachment 149458 [details]
Panel

With this change, my view of the panel is broken, and I can no longer customize it. Every time I log in I get this view.
Comment 6 Fushan Wen 2022-06-04 16:00:53 UTC
(In reply to Victor Ryzhykh from comment #5)
> Created attachment 149458 [details]
> Panel
> 
> With this change, my view of the panel is broken, and I can no longer
> customize it. Every time I log in I get this view.

Do you mean the task manager applet is not expanded?
Comment 7 Victor Ryzhykh 2022-06-04 16:28:56 UTC
Created attachment 149461 [details]
Rever view

No, I'm talking about the other one. All the icons on the panel began to shuffle in random order. After each login to the session in different ways. And the order changes from right to left. Reverted that comment and the panel looks like normal again. This is how it looks now, as it was set up.
Comment 8 Victor Ryzhykh 2022-06-04 17:04:45 UTC
Created attachment 149464 [details]
layout.js file

I use this default panel file in /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js
Comment 9 Fushan Wen 2022-06-04 17:08:26 UTC
Created attachment 149465 [details]
test_fix1.tar.gz

Can you test if the bug is fixed by the 3 files in the archive? Copy them to /usr/share/plasma/plasmoids/org.kde.panel/contents/ui/
Comment 10 Victor Ryzhykh 2022-06-04 17:32:13 UTC
(In reply to Fushan Wen from comment #9)
> Created attachment 149465 [details]
> test_fix1.tar.gz
> 
> Can you test if the bug is fixed by the 3 files in the archive? Copy them to
> /usr/share/plasma/plasmoids/org.kde.panel/contents/ui/

Yes, it works normally now. The panel looks exactly as intended.