Created attachment 149273 [details] Krunnner journal while triggering the bug SUMMARY *** NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols. See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports *** If a runner's match output is longer than 3 lines krunners freezes because of a binding loop detected. I used the translator runner with setMultiline result enabled from here: https://github.com/Thaodan/krunner-translator/tree/multiline Operating System: Arch Linux KDE Plasma Version: 5.24.5 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.4 Kernel Version: 5.17.0-pf1-1 (64-bit) Graphics Platform: X11 Processors: 64 × AMD Ryzen Threadripper 3970X 32-Core Processor Memory: 94.2 GiB of RAM Graphics Processor: AMD Radeon RX 6900 XT
What query do you run to trigger the issue? When typing the example queries from the readme, it works as expected.
(In reply to Alexander Lohnau from comment #1) > What query do you run to trigger the issue? When typing the example queries > from the readme, it works as expected. Something that is longer than 3 lines, also make sure you have the version build that sets setMultiline(true);
E.g. try this line: fi-en voisin väittää että ukuritsat ja malinat on ainakin venäläistä alkuperää, voisin väittää että perunasta puhuvat kartoskana
The issue seems that with the text and the wrap mode set to WordWrap the height of the displayLabel and height of the labelWrapper have a binding loop. I honestly have no idea how to fix that. In the help runner some texts are more than 3 lines long, but have explicit linebreaks with the styled text markup.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/milou/-/merge_requests/41
Git commit 19dc0f02871664b0d1211b0d17b6e4335870b838 by Ismael Asensio. Committed on 29/05/2022 at 10:19. Pushed by iasensio into branch 'master'. ResultDelegate: Fix height binding loop on multiline This binding loop was making krunner freeze when the text expanded more than 3 lines We shouldn't be setting the `height` on an item based on their childrens height. Luckily, the Layout automatically calculates this for us FIXED-IN: 5.24.6 M +3 -1 lib/qml/ResultDelegate.qml https://invent.kde.org/plasma/milou/commit/19dc0f02871664b0d1211b0d17b6e4335870b838
Git commit 2a735f5f80a1c5b436685739af51ff19647a50fa by Ismael Asensio. Committed on 29/05/2022 at 10:33. Pushed by iasensio into branch 'Plasma/5.24'. ResultDelegate: Fix height binding loop on multiline This binding loop was making krunner freeze when the text expanded more than 3 lines We shouldn't be setting the `height` on an item based on their childrens height. Luckily, the Layout automatically calculates this for us FIXED-IN: 5.24.6 (cherry picked from commit 19dc0f02871664b0d1211b0d17b6e4335870b838) M +3 -1 lib/qml/ResultDelegate.qml https://invent.kde.org/plasma/milou/commit/2a735f5f80a1c5b436685739af51ff19647a50fa
Git commit 5fb4b00f494b004b1f3428df09640f6b0fbbbb83 by Ismael Asensio. Committed on 29/05/2022 at 10:35. Pushed by iasensio into branch 'Plasma/5.25'. ResultDelegate: Fix height binding loop on multiline This binding loop was making krunner freeze when the text expanded more than 3 lines We shouldn't be setting the `height` on an item based on their childrens height. Luckily, the Layout automatically calculates this for us FIXED-IN: 5.24.6 (cherry picked from commit 19dc0f02871664b0d1211b0d17b6e4335870b838) M +3 -1 lib/qml/ResultDelegate.qml https://invent.kde.org/plasma/milou/commit/5fb4b00f494b004b1f3428df09640f6b0fbbbb83
(In reply to Ismael Asensio from comment #6) > Git commit 19dc0f02871664b0d1211b0d17b6e4335870b838 by Ismael Asensio. > Committed on 29/05/2022 at 10:19. > Pushed by iasensio into branch 'master'. > > ResultDelegate: Fix height binding loop on multiline > > This binding loop was making krunner freeze when the > text expanded more than 3 lines > > We shouldn't be setting the `height` on an item based on their > childrens height. Luckily, the Layout automatically calculates > this for us > FIXED-IN: 5.24.6 > > M +3 -1 lib/qml/ResultDelegate.qml > > https://invent.kde.org/plasma/milou/commit/ > 19dc0f02871664b0d1211b0d17b6e4335870b838 I tried the commit, it is better however krunner still looks up after the commit.
(In reply to Thaodan from comment #9) > (In reply to Ismael Asensio from comment #6) > > Git commit 19dc0f02871664b0d1211b0d17b6e4335870b838 by Ismael Asensio. > > Committed on 29/05/2022 at 10:19. > > Pushed by iasensio into branch 'master'. > > > > ResultDelegate: Fix height binding loop on multiline > > > > This binding loop was making krunner freeze when the > > text expanded more than 3 lines > > > > We shouldn't be setting the `height` on an item based on their > > childrens height. Luckily, the Layout automatically calculates > > this for us > > FIXED-IN: 5.24.6 > > > > M +3 -1 lib/qml/ResultDelegate.qml > > > > https://invent.kde.org/plasma/milou/commit/ > > 19dc0f02871664b0d1211b0d17b6e4335870b838 > > I tried the commit, it is better however krunner still looks up after the > commit. What do you mean that it 'looks up'? This is suppose to fix the freezing due to the binding loop
(In reply to Ismael Asensio from comment #10) > (In reply to Thaodan from comment #9) > > (In reply to Ismael Asensio from comment #6) > > > Git commit 19dc0f02871664b0d1211b0d17b6e4335870b838 by Ismael Asensio. > > > Committed on 29/05/2022 at 10:19. > > > Pushed by iasensio into branch 'master'. > > > > > > ResultDelegate: Fix height binding loop on multiline > > > > > > This binding loop was making krunner freeze when the > > > text expanded more than 3 lines > > > > > > We shouldn't be setting the `height` on an item based on their > > > childrens height. Luckily, the Layout automatically calculates > > > this for us > > > FIXED-IN: 5.24.6 > > > > > > M +3 -1 lib/qml/ResultDelegate.qml > > > > > > https://invent.kde.org/plasma/milou/commit/ > > > 19dc0f02871664b0d1211b0d17b6e4335870b838 > > > > I tried the commit, it is better however krunner still looks up after the > > commit. > > What do you mean that it 'looks up'? This is suppose to fix the freezing > due to the binding loop When I just applied the commit above to the version mentioned in the bug report krunner still die freeze after three lines but now everything is fine.