Bug 454416 - The "Empty Grouping Plasmoid" and "Empty System Tray" options on the desktop "Add Panel" submenu that do nothing
Summary: The "Empty Grouping Plasmoid" and "Empty System Tray" options on the desktop ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 5.24.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 459388 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-26 03:28 UTC by zocsfxljsgpmiuaanz
Modified: 2022-09-23 16:18 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.26
Sentry Crash Report:


Attachments
attachment-9687-0.html (1.52 KB, text/html)
2022-09-23 13:08 UTC, mkkDr2010
Details

Note You need to log in before you can comment on or make changes to this bug.
Description zocsfxljsgpmiuaanz 2022-05-26 03:28:55 UTC
SUMMARY
Title. I'm not sure when those options were added but they do nothing when clicked.

STEPS TO REPRODUCE
1. Open the right-click menu on the desktop
2. Click on "Empty Grouping Plasmoid" or "Empty System Tray" on the "Add Panel" submenu

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Something happens.

SOFTWARE/OS VERSIONS
Operating System: Gentoo Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Bacteria 2022-05-26 05:04:11 UTC
Can reproduce

Operating System: Arch Linux
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Graphics Platform: Wayland
Comment 2 Nate Graham 2022-05-26 16:39:10 UTC
Also confirmed.
Comment 3 Nate Graham 2022-09-22 18:28:34 UTC
*** Bug 459388 has been marked as a duplicate of this bug. ***
Comment 4 Marco Martin 2022-09-23 12:49:01 UTC
those plasmoids are technically containments but they are not supposed or supported to be used as panels, they are internal things that should never be user facing.
simply they should not be listed there
Comment 5 Alexander Lohnau 2022-09-23 12:59:44 UTC
@Marco Should then only layout templates be listed there?
Comment 6 mkkDr2010 2022-09-23 13:08:10 UTC
Created attachment 152366 [details]
attachment-9687-0.html

Yes, I agree with that. Grouping Plasmoids is available as widget for desktop and System Tray is for panel. So these elements are not necessary in Add Panel. 


Am Freitag, September 23, 2022, 2:49 PM schrieb Marco Martin <bugzilla_noreply@kde.org>:

https://bugs.kde.org/show_bug.cgi?id=454416

--- Comment #4 from Marco Martin <notmart@gmail.com> ---
those plasmoids are technically containments but they are not supposed or
supported to be used as panels, they are internal things that should never be
user facing.
simply they should not be listed there
Comment 7 Bug Janitor Service 2022-09-23 14:16:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2160
Comment 8 Bug Janitor Service 2022-09-23 14:19:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/235
Comment 9 Nate Graham 2022-09-23 16:16:42 UTC
Git commit 30330a86bb9ade7e468780a3241a95636509142a by Nate Graham, on behalf of Marco Martin.
Committed on 23/09/2022 at 16:16.
Pushed by ngraham into branch 'master'.

Remove ContainmentType from the grouping container plasmoid

The grouping container plasmoid is *not* a containment, but is a normal
applet that does some hack to display the contents of the internal
grouping applet which *is* one.

Since plasma-framework is built with
if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89)

now everything that has the containmentype key is considered as a
containment, and now the grouping plasmoid is listed in the "add panel"
menu, however it doesn't really work there.
that key was wrong from there to begin with.
FIXED-IN: 5.26

M  +0    -1    applets/grouping/container/package/metadata.json

https://invent.kde.org/plasma/kdeplasma-addons/commit/30330a86bb9ade7e468780a3241a95636509142a
Comment 10 Nate Graham 2022-09-23 16:17:25 UTC
Git commit dfab9de90dd311f9078d75369e849af424f47ae6 by Nate Graham, on behalf of Marco Martin.
Committed on 23/09/2022 at 16:17.
Pushed by ngraham into branch 'master'.

Remove ContainmentType from the systray container plasmoid

The systray container plasmoid is *not* a containment, but is a normal
applet that does some hack to display the contents of the internal
systray applet which *is* one.

Since plasma-framework is built with
if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89)

now everything that has the containmentype key is considered as a
containment, and now the systray is listed in the "add panel" menu,
however it doesn't really work there.
that key was wrong from there to begin wwith. After some testing
there doesn't seem to be any behavior difference of the systary plasmoid
when used
FIXED-IN: 5.26

M  +0    -1    applets/systemtray/container/package/metadata.json

https://invent.kde.org/plasma/plasma-workspace/commit/dfab9de90dd311f9078d75369e849af424f47ae6
Comment 11 Nate Graham 2022-09-23 16:17:45 UTC
Git commit 1eede278e43a85e4bb12b13cd4462eb8ec36698b by Nate Graham, on behalf of Marco Martin.
Committed on 23/09/2022 at 16:17.
Pushed by ngraham into branch 'Plasma/5.26'.

Remove ContainmentType from the grouping container plasmoid

The grouping container plasmoid is *not* a containment, but is a normal
applet that does some hack to display the contents of the internal
grouping applet which *is* one.

Since plasma-framework is built with
if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89)

now everything that has the containmentype key is considered as a
containment, and now the grouping plasmoid is listed in the "add panel"
menu, however it doesn't really work there.
that key was wrong from there to begin with.
FIXED-IN: 5.26


(cherry picked from commit 30330a86bb9ade7e468780a3241a95636509142a)

M  +0    -1    applets/grouping/container/package/metadata.json

https://invent.kde.org/plasma/kdeplasma-addons/commit/1eede278e43a85e4bb12b13cd4462eb8ec36698b
Comment 12 Nate Graham 2022-09-23 16:18:07 UTC
Git commit 02287d5490e6fd4bcc4de9a88e614e8cb79176f8 by Nate Graham, on behalf of Marco Martin.
Committed on 23/09/2022 at 16:18.
Pushed by ngraham into branch 'Plasma/5.26'.

Remove ContainmentType from the systray container plasmoid

The systray container plasmoid is *not* a containment, but is a normal
applet that does some hack to display the contents of the internal
systray applet which *is* one.

Since plasma-framework is built with
if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89)

now everything that has the containmentype key is considered as a
containment, and now the systray is listed in the "add panel" menu,
however it doesn't really work there.
that key was wrong from there to begin wwith. After some testing
there doesn't seem to be any behavior difference of the systary plasmoid
when used
FIXED-IN: 5.26


(cherry picked from commit dfab9de90dd311f9078d75369e849af424f47ae6)

M  +0    -1    applets/systemtray/container/package/metadata.json

https://invent.kde.org/plasma/plasma-workspace/commit/02287d5490e6fd4bcc4de9a88e614e8cb79176f8