Bug 454397 - Excessive shortcut to lock screen
Summary: Excessive shortcut to lock screen
Status: RESOLVED FIXED
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-25 15:56 UTC by Egor
Modified: 2022-05-27 12:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25
Sentry Crash Report:


Attachments
two shortcuts enabled by default (72.92 KB, image/png)
2022-05-25 15:56 UTC, Egor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Egor 2022-05-25 15:56:09 UTC
Created attachment 149210 [details]
two shortcuts enabled by default

ctrl+alt+l is a global shortcut without using meta key. It can be used by some software (for example ctrl+alt+l is a popular shortcut in a jetbrains software kit).
Comment 1 John 2022-05-26 11:04:53 UTC
I agree!

I have always used just the Meta+L as that's the key combination that I'm used to coming from Windows 7.
Also I didn't know about the CTRL+ALT+L (until now), but even if I did, I would probably never used it as it requires more keys.

As a phpStorm user this affects me too:
https://www.jetbrains.com/help/phpstorm/mastering-keyboard-shortcuts.html?q=Ctrl%2BAlt%2BL&s=full
Comment 2 Nate Graham 2022-05-26 16:45:02 UTC
I believe the Ctrl+Alt+L shortcut is older, before we had the Meta+L shortcut, and before there was a FreeDesktop spec suggesting that global shortcuts use the Meta key. The reason for this spec is to resolve exactly the issue you raised: global shortcuts interfering with app shortcuts and breaking apps. That's definitely not good. It's probably time to remove the old shortcut.
Comment 3 Bug Janitor Service 2022-05-26 16:56:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/76
Comment 4 Nate Graham 2022-05-27 12:19:10 UTC
Git commit 0ce96496f52c3dc8d7c6d4dddf668ec9c6f60514 by Nate Graham.
Committed on 26/05/2022 at 20:21.
Pushed by ngraham into branch 'master'.

Remove old non-compliant Ctrl+Alt+L shortcut that interferes with apps

KScreenLocker lets the user lock the screen with the Meta+L and
Ctrl+Alt+L shortcuts by default. This latter shortcut has been reported
by users to conflict with the Ctrl+Alt+L shortcut in at least one
user-facing app. System components shouldn't break apps by masking
their shortcuts.

This commit removes the Ctrl+Alt+L shortcut, leaving only Meta+L. This
un-breaks userspace apps using that shortcut.
FIXED-IN: 5.25

M  +1    -1    settings/kscreensaversettings.cpp

https://invent.kde.org/plasma/kscreenlocker/commit/0ce96496f52c3dc8d7c6d4dddf668ec9c6f60514
Comment 5 Nate Graham 2022-05-27 12:30:12 UTC
Git commit e26fb2263f406382081291a7bb8a7b8d94f65ea5 by Nate Graham.
Committed on 27/05/2022 at 12:30.
Pushed by ngraham into branch 'Plasma/5.25'.

Remove old non-compliant Ctrl+Alt+L shortcut that interferes with apps

KScreenLocker lets the user lock the screen with the Meta+L and
Ctrl+Alt+L shortcuts by default. This latter shortcut has been reported
by users to conflict with the Ctrl+Alt+L shortcut in at least one
user-facing app. System components shouldn't break apps by masking
their shortcuts.

This commit removes the Ctrl+Alt+L shortcut, leaving only Meta+L. This
un-breaks userspace apps using that shortcut.
FIXED-IN: 5.25


(cherry picked from commit 0ce96496f52c3dc8d7c6d4dddf668ec9c6f60514)

M  +1    -1    settings/kscreensaversettings.cpp

https://invent.kde.org/plasma/kscreenlocker/commit/e26fb2263f406382081291a7bb8a7b8d94f65ea5