Bug 454318 - Save as Version in Imageeditor not accessible when using external raw editor (rawtherapee)
Summary: Save as Version in Imageeditor not accessible when using external raw editor ...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Versioning (other bugs)
Version First Reported In: 7.6.0
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-24 09:33 UTC by Juergen
Modified: 2022-05-24 18:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen 2022-05-24 09:33:49 UTC
SUMMARY
Save as Version in Imageeditor not accessible when using external raw editor (rawtherapee)
***
If rawtherapee is set as an external raw processor, this will also be started. When rawtherapee is closed, the edited result is displayed in the image editor. However, only the "Export" option is available for saving. It would be good if the "Save as Version" option was also available. However, this only becomes active if additional processing has been carried out with one of the original digikam tools.
***
STEPS TO REPRODUCE
1. Start/End edit a raw file with digikam using rawtherapee as raw editor 

OBSERVED RESULT
In Imageedit View only the export button is activ

EXPECTED RESULT
In Imageedit the save as Verion button is also activ

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Win/digikam/rawtherapee run in language de
Comment 1 Maik Qualmann 2022-05-24 11:14:21 UTC
We need to add a simple image history after loading the image in an external editor. The "DocumentedHistory" type as a non-reproducible filter would be appropriate. I will implement it.

Maik
Comment 2 Maik Qualmann 2022-05-24 18:43:27 UTC
Git commit 8f4ab809101a515edb8252330b0895a906694d02 by Maik Qualmann.
Committed on 24/05/2022 at 18:42.
Pushed by mqualmann into branch 'master'.

add history step for external Raw decoders
FIXED-IN: 8.0.0

M  +2    -1    NEWS
M  +8    -0    core/dplugins/rawimport/darktable/rawimportdarktableplugin.cpp
M  +8    -0    core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.cpp
M  +17   -12   core/dplugins/rawimport/ufraw/rawimportufrawplugin.cpp
M  +5    -2    core/libs/dimg/filters/dimgfiltermanager.cpp

https://invent.kde.org/graphics/digikam/commit/8f4ab809101a515edb8252330b0895a906694d02