Bug 454241 - Saving YCbCr TIFF files is broken
Summary: Saving YCbCr TIFF files is broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Compiled Sources Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-23 00:06 UTC by amyspark
Modified: 2022-06-28 17:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description amyspark 2022-05-23 00:06:20 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

As of current master (commit 5afaa035d8e46d1dcdd351f86b5b7e83f3631bf6) it's impossible to save YCbCr TIFF files. Even when accounting for the given color space (which is unimplemented, and has been so for the past decade), attempting to save the TIFF file fails with a null pointer dereference because we call the wrong function  to estimate the strip size.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10 21H2
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 5.12.12

ADDITIONAL INFORMATION

libtiff 4.3.0 + photoshop patch
Comment 1 amyspark 2022-06-28 17:04:54 UTC
Git commit 5eb2e59853daa35968b957a05d6d3b17ca9e8106 by L. E. Segovia.
Committed on 28/06/2022 at 16:01.
Pushed by lsegovia into branch 'master'.

tiff: implement export as YCbCr

M  +1    -1    plugins/impex/tiff/kis_tiff_converter.cc
M  +3    -1    plugins/impex/tiff/kis_tiff_converter.h
M  +4    -0    plugins/impex/tiff/kis_tiff_export.cc
M  +30   -1    plugins/impex/tiff/kis_tiff_psd_writer_visitor.cpp
M  +30   -1    plugins/impex/tiff/kis_tiff_writer_visitor.cpp

https://invent.kde.org/graphics/krita/commit/5eb2e59853daa35968b957a05d6d3b17ca9e8106
Comment 2 amyspark 2022-06-28 17:31:01 UTC
Git commit b6c763ad91742fdd2b47384e1c82051b839173f3 by L. E. Segovia.
Committed on 28/06/2022 at 17:29.
Pushed by lsegovia into branch 'krita/5.1'.

tiff: implement export as YCbCr
(cherry picked from commit 5eb2e59853daa35968b957a05d6d3b17ca9e8106)

M  +1    -1    plugins/impex/tiff/kis_tiff_converter.cc
M  +3    -1    plugins/impex/tiff/kis_tiff_converter.h
M  +4    -0    plugins/impex/tiff/kis_tiff_export.cc
M  +30   -1    plugins/impex/tiff/kis_tiff_psd_writer_visitor.cpp
M  +30   -1    plugins/impex/tiff/kis_tiff_writer_visitor.cpp

https://invent.kde.org/graphics/krita/commit/b6c763ad91742fdd2b47384e1c82051b839173f3