Created attachment 149057 [details]
Some strings followed by equals signs when input into krunner will cause the calculator runner to output garbage. (some will crash krunner entirely, see https://bugs.kde.org/show_bug.cgi?id=454130)
STEPS TO REPRODUCE
Type certain phrases followed by equals signs into krunner
Gibberish from calculator krunner
Calculator runner should probably not be parsing strings like this
(available in About System)
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Created attachment 149058 [details]
Here's another example.
I could not find an easy way to detect an error from evaluating the qalculate statement. Unless anyone has ideas, I will open an issue on their Github tracker.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1856
Git commit 4b35701a31092e25e5226205d550dc294737a69a by Alexander Lohnau.
Committed on 25/07/2022 at 15:05.
Pushed by alex into branch 'master'.
runners/calculator: Do not show results when expression is invalid
See https://github.com/Qalculate/libqalculate/issues/442 for the code snippets.
I have only adjusted those to compile inside of the plugin.
M +7 -0 runners/calculator/autotests/calculatorrunnertest.cpp
M +40 -0 runners/calculator/qalculate_engine.cpp