Bug 454032 - When using a language other than English, inline buttons of initial view don't work until you switch views once
Summary: When using a language other than English, inline buttons of initial view don'...
Status: RESOLVED DUPLICATE of bug 467348
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 22.04.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-19 06:14 UTC by PK
Modified: 2023-04-20 13:40 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
konsole output of startup elisa (7.84 KB, text/plain)
2022-05-19 18:14 UTC, PK
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PK 2022-05-19 06:14:00 UTC
SUMMARY

When I try to use the controls (+ to add, triangle to replace the playing list) on the cover of the albums in the music-list of Elisa nothing happens.

STEPS TO REPRODUCE
1. use the "cover controls" of Elisa (version 22.04.1)

OBSERVED RESULT

nothing happens

EXPECTED RESULT

On using the + sign: add to playing list on using the triangle replace playing list

Elisa: versie 22.04.1, frameworks 5.94, qt 5.13 built against 5.13

Operating System: Kubuntu 22.04
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Kernel Version: 5.15.0-30-generic (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i5-4300U CPU @ 1.90GHz
Memory: 3.7 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 4400
Comment 1 Nate Graham 2022-05-19 17:06:24 UTC
Works for me. Any chance you could attach a screen recording that shows the issue?

Also, can you run Elisa from a terminal window (type `elisa`) and report any errors printed to the window when you click the button and it doesn't do anything?

Thanks!
Comment 2 PK 2022-05-19 18:12:35 UTC
First we made a recording of this behavior. As you can see we click on the "cover controls" and nothing happens. 
- not with the playing list but also
- no output in the konsole
Here is the recording https://photos.app.goo.gl/vb2krqFHWoNiM3LE7
Comment 3 PK 2022-05-19 18:14:24 UTC
Created attachment 149006 [details]
konsole output of startup elisa

This is the konsole output of starting up and running elisa
Comment 4 Nate Graham 2022-05-23 14:20:40 UTC
Thank you for the video, that's helpful.

Does this happen only when you click on the inline buttons for albums? how about if you do it for artists, or genres?
Comment 5 PK 2022-05-23 14:49:13 UTC
I tried the inline buttons for artists and genres, they work absolutely fine...
Comment 6 Nate Graham 2022-05-23 15:47:56 UTC
Well that's strange.

If you click "Refresh Music Collection" in the hamburger menu and then restart the app twice, does the problem go away?
Comment 7 PK 2022-05-23 16:05:01 UTC
No, it doesn't go away. I tried....
Comment 8 PK 2022-05-23 17:10:03 UTC
(In reply to Nate Graham from comment #6)
> Well that's strange.
> 
> If you click "Refresh Music Collection" in the hamburger menu and then
> restart the app twice, does the problem go away?

To make it even stranger... I just discovered that the "inline buttons for albums" work when I used the inline buttons for genres or even artists and immediately after use the inline buttons for the albums. Then the inline buttons for albums work exactly as they should.
Comment 9 PK 2022-05-24 04:33:45 UTC
With the version 22.04.1 I can once again open Elisa with the focus on the albums. 
With my discovery of yesterday evening, and thanks to the questions of Nate Graham, I guess that what this bug boils down to is that: 
when I let Elisa start up in the "album view" then the inline buttons in that view don't work.
Comment 10 PK 2022-05-24 05:15:37 UTC
Now I notice that this goes the same for the genre- and the artists view. There the inline buttons do not work directly after startup. Only after switching to another view they work.
Comment 11 Nate Graham 2022-05-24 15:16:10 UTC
Nice job narrowing it down. Unfortunately I still cannot reproduce the issue of whatever view is initially opened having non-functional inline buttons.
Comment 12 PK 2022-05-24 15:29:06 UTC
Perhaps it has anything to do with the work that is recently done on Elisa that made is once again possible for non English users to open Elisa in an other view than "playing now". 
With the version 22.04.1 I can do that. 
But perhaps something went wrong in the coding.
Comment 13 Firlaev-Hans 2022-06-01 18:45:38 UTC
Can confirm on multiple german systems with both 22.04 and master.
Comment 14 Nate Graham 2022-08-12 19:47:02 UTC
*** Bug 457804 has been marked as a duplicate of this bug. ***
Comment 15 PK 2022-08-24 06:41:00 UTC
To my regret this bug isn't fixed in Gear 22.08.
Comment 16 Yerrey Dev 2022-08-25 12:28:42 UTC
I was looking into this, and seems that inlining ElisaApplication.mediaPlayListProxyModel.enqueue(...) into the onReplaceAndPlay in DataGridView.qml (like it is done in DataListView) does solve this bug, but I'm not exactly sure if the currently implemented signal approach has any functional difference to that. Currently it calls from DataGridView -> GridViewProxyModel -> AbstractMediaProxyModel -> mediaPlayListProxyModel, which we could just skip from DataGridView -> mediaPlayListProxyModel.

I couldn't troubleshoot what the actual problem is with the current implementation, but we never arrive at MediaPlayListProxyModel::enqueue after calling the signal Q_EMIT entriesToEnqueue from abstractMediaProxyModel.
Comment 17 PK 2022-09-10 12:27:31 UTC
Works on my system now. I guess since Gear 22.08.1.
This is great! Many thanks!
Comment 18 PK 2022-09-10 13:17:56 UTC
Really strange... It just worked. It was the first run on a newly installed system.
Now it doesn't work anymore...
Comment 19 PK 2022-12-11 17:25:03 UTC
Gear 22.12 and it still isn't fixed. Please fix this.
Comment 20 Jack Hill 2023-04-11 11:16:28 UTC

*** This bug has been marked as a duplicate of bug 467348 ***
Comment 21 PK 2023-04-20 13:39:20 UTC
I cannot code myself so one way to help is to make bug rapports. Thank you so much for solving this bug. Elisa is really something special...
Comment 22 Nate Graham 2023-04-20 13:40:07 UTC
I'm so glad you're happy with it! Thanks for the kind words.