Bug 453975 - Missing find_package(Qt5 COMPONENTS WaylandClientPrivate)
Summary: Missing find_package(Qt5 COMPONENTS WaylandClientPrivate)
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-18 10:06 UTC by Louis Moureaux
Modified: 2022-07-23 03:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Complete configure+generate log (21.84 KB, text/x-log)
2022-05-18 10:06 UTC, Louis Moureaux
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Louis Moureaux 2022-05-18 10:06:15 UTC
Created attachment 148941 [details]
Complete configure+generate log

SUMMARY

Plasma apparently requires WaylandClientPrivate, but its availability isn't checked with a find_package call. This causes a failure when generating the build system.

STEPS TO REPRODUCE

Use Kde Neon.

1. Make sure "qtwayland5-private-dev" is not installed
2. Configure plasma-workspace through kdesrc-build, using system Qt (I also used Neon packages for other dependencies)
3. See it fail, read the log

OBSERVED RESULT

CMake fails to generate with (full log in attachment):

CMake Error at /usr/lib/x86_64-linux-gnu/cmake/KF5CoreAddons/KF5CoreAddonsMacros.cmake:182 (add_library):
  Target "appmenu" links to target "Qt::WaylandClientPrivate" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  appmenu/CMakeLists.txt:16 (kcoreaddons_add_plugin)

EXPECTED RESULT

find_package() reports a missing component.
Note that qtwayland5-private-dev doesn't provide WaylandClientPrivateConfig.cmake so we may need to write a find module.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kde Neon user
(available in About System)
KDE Plasma Version: master = c0cb9f9929cfca683313252ebe95a0ac2b62f6e8
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3 as in Neon
Comment 1 Nate Graham 2022-05-18 16:12:26 UTC
Good catch. Wanna submit a merge request to fix it?
Comment 2 Bug Janitor Service 2022-05-21 17:39:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1757
Comment 3 Bug Janitor Service 2022-05-21 17:39:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1757
Comment 4 Nate Graham 2022-07-23 03:06:39 UTC
Git commit eb594ea713f492533a266d4683eab7d0ec7bd323 by Nate Graham, on behalf of Louis Moureaux.
Committed on 23/07/2022 at 03:00.
Pushed by ngraham into branch 'master'.

CMake: Check for Qt::WaylandPrivate

M  +1    -1    CMakeLists.txt

https://invent.kde.org/plasma/plasma-workspace/commit/eb594ea713f492533a266d4683eab7d0ec7bd323