Bug 453945 - GMIC:the selection area causes the picture position to shift
Summary: GMIC:the selection area causes the picture position to shift
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-17 18:21 UTC by thetwo
Modified: 2022-05-26 14:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
gif (377.21 KB, image/gif)
2022-05-17 18:21 UTC, thetwo
Details
pic (11.17 KB, image/png)
2022-05-17 18:26 UTC, thetwo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description thetwo 2022-05-17 18:21:05 UTC
Created attachment 148925 [details]
gif

SUMMARY
krita-nightly-x64-5.1.0-prealpha-d59747b8ad

This is different from 453477. The reason for 453477 is to export multiple layers, and this report is about selection.

When you create a selection and use the GMIC filter, everything in the layer will align with the upper left corner of the selection, causing things in the selection to move very far away.
Comment 1 thetwo 2022-05-17 18:26:27 UTC
Created attachment 148926 [details]
pic

The closer the selection is to the upper left corner, the smaller the offset occurs; the closer the selection is to the lower right corner, the larger the offset occurs.
Comment 2 amyspark 2022-05-17 20:31:34 UTC
I need the specific filters that you've tested along with any custom configuration. If you can send test KRAs, that would be very helpful too.

We rely on G'MIC telling us the position of the contents, so it's really possible that it's telling us (0, 0) -- in which case everything will get aligned with the top left, nomatter what the current layer's position is.
Comment 3 amyspark 2022-05-25 18:12:32 UTC
We are repositioning the layers nomatter if a selection is active.
Comment 4 Bug Janitor Service 2022-05-26 00:47:23 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1459
Comment 5 amyspark 2022-05-26 14:27:42 UTC
Git commit 9ae3a454ea1ccb8cc5c9793f73f7662d55bd9601 by L. E. Segovia.
Committed on 26/05/2022 at 13:29.
Pushed by lsegovia into branch 'master'.

G'MIC: only reposition layer if no selection is active

M  +5    -2    plugins/extensions/qmic/kis_qmic_import_tools.h
M  +4    -1    plugins/extensions/qmic/kis_qmic_processing_visitor.cpp
M  +4    -1    plugins/extensions/qmic/kis_qmic_synchronize_layers_command.cpp

https://invent.kde.org/graphics/krita/commit/9ae3a454ea1ccb8cc5c9793f73f7662d55bd9601
Comment 6 amyspark 2022-05-26 14:28:14 UTC
Git commit 73fbcfb137b7a88e5b179fae7da9e4f238a8b109 by L. E. Segovia.
Committed on 26/05/2022 at 13:29.
Pushed by lsegovia into branch 'master'.

Update G'MIC to 3.1.2.2
Related: bug 453947, bug 453949, bug 454100, bug 454286

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt [INFRASTRUCTURE]

https://invent.kde.org/graphics/krita/commit/73fbcfb137b7a88e5b179fae7da9e4f238a8b109