Bug 453914 - Incorrect rendering of the error window in widget downloader
Summary: Incorrect rendering of the error window in widget downloader
Status: RESOLVED DUPLICATE of bug 451538
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.92.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-16 22:45 UTC by Lastique
Modified: 2022-05-17 16:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot illustrating the problem. (62.34 KB, image/png)
2022-05-16 22:45 UTC, Lastique
Details
Screenshot illustrating the problem with Breeze icon theme. (258.16 KB, image/png)
2022-05-17 15:28 UTC, Lastique
Details
Screenshot with Breeze window decorations. (130.64 KB, image/png)
2022-05-17 15:28 UTC, Lastique
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lastique 2022-05-16 22:45:21 UTC
Created attachment 148901 [details]
Screenshot illustrating the problem.

SUMMARY

In continuation of https://bugs.kde.org/show_bug.cgi?id=453792.

If an error occurs while getting the list of widgets available for download, the error is displayed in an incorrectly rendered window. The "close window" button is rendered black and the whole styling does not follow system theme. See the attached screenshot.

STEPS TO REPRODUCE

1. Right-click on desktop and select Add Widgets.
2. Click Get New Widgets.
3. Make sure a connection error happens while accessing KDE store. In my case I had genuine connectivity issues. It may reproduce if network connection is down.

OBSERVED RESULT

An error is displayed. The error window is not rendered according to the system theme (see the screenshot, the "close window" button is rendered black).

EXPECTED RESULT

The window should be rendered according to the system theme.

SOFTWARE/OS VERSIONS

Operating System: Kubuntu 22.04
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3
Kernel Version: 5.15.0-30-lowlatency (64-bit)
Graphics Platform: X11
Processors: 16 × 12th Gen Intel® Core™ i7-12700K
Memory: 31.1 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2
Comment 1 Nate Graham 2022-05-17 14:31:33 UTC
> The error window is not rendered according to the system theme
This is intentional, because it's actually not a real window. It's just a little in-window popup. We don't want to confuse you into thinking that it is a real window, because it's not.

> the "close window" button is rendered black
That's a bug we can fix though.

What icon theme are you using? Looks like Oxygen? If you temporarily switch to the Breeze icon theme, does the close button look better?
Comment 2 Lastique 2022-05-17 14:49:36 UTC
(In reply to Nate Graham from comment #1)
> > The error window is not rendered according to the system theme
> This is intentional, because it's actually not a real window. It's just a
> little in-window popup. We don't want to confuse you into thinking that it
> is a real window, because it's not.

Is there a reason to make it a custom window though? Just make it a normal window, which should fix everything.

> > the "close window" button is rendered black
> That's a bug we can fix though.
> 
> What icon theme are you using? Looks like Oxygen?

Yes, it's Oxygen.

> If you temporarily switch
> to the Breeze icon theme, does the close button look better?

Unfortunately, network problems don't reproduce for me today, so I can't get the error window to show up. Disconnecting network doesn't help, as there must be some cached content in the widget downloader - it just displays a list of widgets, only without images. I'm not sure how to trigger a network problem locally.
Comment 3 Nate Graham 2022-05-17 14:58:16 UTC
(In reply to Lastique from comment #2)
> Is there a reason to make it a custom window though? Just make it a normal
> window, which should fix everything.
It's a design decision, sorry. For the moment we're sticking with this approach.

> Unfortunately, network problems don't reproduce for me today, so I can't get
> the error window to show up. Disconnecting network doesn't help, as there
> must be some cached content in the widget downloader - it just displays a
> list of widgets, only without images. I'm not sure how to trigger a network
> problem locally.
Maybe you could disconnect from the network and attempt to download something?
Comment 4 Lastique 2022-05-17 15:28:27 UTC
Created attachment 148918 [details]
Screenshot illustrating the problem with Breeze icon theme.

(In reply to Nate Graham from comment #3)
> (In reply to Lastique from comment #2)
> 
> > Unfortunately, network problems don't reproduce for me today, so I can't get
> > the error window to show up. Disconnecting network doesn't help, as there
> > must be some cached content in the widget downloader - it just displays a
> > list of widgets, only without images. I'm not sure how to trigger a network
> > problem locally.
> Maybe you could disconnect from the network and attempt to download
> something?

Reproduced, thanks. See the attached screenshot.

The window closing button is still black. Though I think icon theme is not the issue - it's the window decoration style that doesn't match the window closing button.
Comment 5 Lastique 2022-05-17 15:28:49 UTC
Created attachment 148919 [details]
Screenshot with Breeze window decorations.
Comment 6 Lastique 2022-05-17 15:31:51 UTC
Comment on attachment 148919 [details]
Screenshot with Breeze window decorations.

And here's a screenshot with Breeze window decorations. The close button is still black and doesn't match the other window decorations style.

I think, whatever system settings you try to adjust, this window will still look alien. You may try to change the close button to be not black, but then it will probably look ugly with dark themes.
Comment 7 Nate Graham 2022-05-17 16:31:12 UTC
I'm not asking you to try Breeze *window decorations* but rather Breeze *icons*. Can you try that?
Comment 8 Lastique 2022-05-17 16:42:04 UTC
(In reply to Nate Graham from comment #7)
> I'm not asking you to try Breeze *window decorations* but rather Breeze
> *icons*. Can you try that?

I did, see comment 4.
Comment 9 Nate Graham 2022-05-17 16:47:52 UTC
Aha, thanks. Sorry for missing that. So this is the same root cause as Bug 451538. Hopefully that should be fixed soon, as there is an open merge request for it.

*** This bug has been marked as a duplicate of bug 451538 ***